mirror of
https://github.com/samsonjs/media.git
synced 2026-03-25 09:25:53 +00:00
Add comment about out-of-order timestamps in AtomParsers.parseStbl
PiperOrigin-RevId: 550596173
(cherry picked from commit 449cf55523)
This commit is contained in:
parent
eaf4a2b448
commit
db336d5c74
1 changed files with 7 additions and 0 deletions
|
|
@ -729,6 +729,13 @@ import org.checkerframework.checker.nullness.compatqual.NullableType;
|
|||
long editDuration =
|
||||
Util.scaleLargeTimestamp(
|
||||
track.editListDurations[i], track.timescale, track.movieTimescale);
|
||||
// The timestamps array is in the order read from the media, which might not be strictly
|
||||
// sorted, but will ensure that a) all sync frames are in-order and b) any out-of-order
|
||||
// frames are after their respective sync frames. This means that although the result of
|
||||
// this binary search might be slightly incorrect (due to out-of-order timestamps), the loop
|
||||
// below that walks forward to find the next sync frame will result in a correct start
|
||||
// index. The start index would also be correct if we walk backwards to the previous sync
|
||||
// frame (https://github.com/google/ExoPlayer/issues/1659).
|
||||
startIndices[i] =
|
||||
Util.binarySearchFloor(
|
||||
timestamps, editMediaTime, /* inclusive= */ true, /* stayInBounds= */ true);
|
||||
|
|
|
|||
Loading…
Reference in a new issue