From dc0ee7580ed98ab82e9139b25113832229cd5f93 Mon Sep 17 00:00:00 2001 From: tonihei Date: Wed, 31 Mar 2021 10:44:51 +0100 Subject: [PATCH] Deprecate AnalyticsListener.onSeekStarted. The new onPositionDiscontinuity callback contains sufficient information, so that this former workaround to obtain the position before a seek is no longer needed. PiperOrigin-RevId: 365993937 --- .../android/exoplayer2/analytics/AnalyticsCollector.java | 1 + .../android/exoplayer2/analytics/AnalyticsListener.java | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java index 2f1addebdd..6a0c56caf7 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java @@ -170,6 +170,7 @@ public class AnalyticsCollector * Notify analytics collector that a seek operation will start. Should be called before the player * adjusts its state and position to the seek. */ + @SuppressWarnings("deprecation") // Calling deprecated listener method. public final void notifySeekStarted() { if (!isSeeking) { EventTime eventTime = generateCurrentPlayerMediaPeriodEventTime(); diff --git a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsListener.java b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsListener.java index 61abc0f2e6..643ce08b84 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsListener.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsListener.java @@ -553,10 +553,11 @@ public interface AnalyticsListener { @DiscontinuityReason int reason) {} /** - * Called when a seek operation started. - * - * @param eventTime The event time. + * @deprecated Use {@link #onPositionDiscontinuity(EventTime, Player.PositionInfo, + * Player.PositionInfo, int)} instead, listening to changes with {@link + * Player#DISCONTINUITY_REASON_SEEK}. */ + @Deprecated default void onSeekStarted(EventTime eventTime) {} /**