PiperOrigin-RevId: 601910682
This commit is contained in:
Googler 2024-01-26 17:43:11 -08:00 committed by Copybara-Service
parent 4d5f844c61
commit e0be4c2ff4
2 changed files with 5 additions and 11 deletions

View file

@ -27,7 +27,7 @@ import static androidx.media3.transformer.ExportResult.OPTIMIZATION_FAILED_EXTRA
import static androidx.media3.transformer.ExportResult.OPTIMIZATION_FAILED_FORMAT_MISMATCH;
import static androidx.media3.transformer.TransformerUtil.shouldTranscodeAudio;
import static androidx.media3.transformer.TransformerUtil.shouldTranscodeVideo;
import static androidx.media3.transformer.TransmuxTranscodeHelper.buildUponCompositionForTrimOptimization;
import static androidx.media3.transformer.TransmuxTranscodeHelper.buildNewCompositionWithClipTimes;
import static java.lang.Math.round;
import static java.lang.annotation.ElementType.TYPE_USE;
@ -1397,7 +1397,7 @@ public final class Transformer {
if (mp4Info.firstSyncSampleTimestampUsAfterTimeUs - trimStartTimeUs
<= maxEncodedAudioBufferDurationUs) {
Transformer.this.composition =
buildUponCompositionForTrimOptimization(
buildNewCompositionWithClipTimes(
composition,
mp4Info.firstSyncSampleTimestampUsAfterTimeUs,
firstMediaItem.clippingConfiguration.endPositionUs,
@ -1438,7 +1438,7 @@ public final class Transformer {
}
Transformer.this.mediaItemInfo = mp4Info;
Composition trancodeComposition =
buildUponCompositionForTrimOptimization(
buildNewCompositionWithClipTimes(
composition,
trimStartTimeUs,
mp4Info.firstSyncSampleTimestampUsAfterTimeUs,
@ -1476,7 +1476,7 @@ public final class Transformer {
long trimStartTimeUs = firstEditedMediaItem.mediaItem.clippingConfiguration.startPositionUs;
long trimEndTimeUs = firstEditedMediaItem.mediaItem.clippingConfiguration.endPositionUs;
Composition transmuxComposition =
buildUponCompositionForTrimOptimization(
buildNewCompositionWithClipTimes(
composition,
mediaItemInfo.firstSyncSampleTimestampUsAfterTimeUs,
trimEndTimeUs,

View file

@ -75,11 +75,7 @@ import java.util.List;
return mp4InfoSettableFuture;
}
/**
* Changes the clip times of the {@link MediaItem} in the {@link Composition} and removes any
* video effects that shouldn't be applied during transcoding or transmuxing.
*/
public static Composition buildUponCompositionForTrimOptimization(
public static Composition buildNewCompositionWithClipTimes(
Composition oldComposition,
long startTimeUs,
long endTimeUs,
@ -105,8 +101,6 @@ import java.util.List;
.buildUpon()
.setMediaItem(mediaItem)
.setDurationUs(mediaDurationUs)
.setEffects(
new Effects(firstEditedMediaItem.effects.audioProcessors, ImmutableList.of()))
.build();
return oldComposition