sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-03 10:55:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

AudioSink: Remove comment about unconfirmed crash

Browse source 
Consensus is that the NoClassDefFoundError does not
causes a crash but only a warning.

PiperOrigin-RevId: 338022354
This commit is contained in:
krocard 2020-10-20 10:18:43 +01:00 committed by Oliver Woodman
parent 7303005873
commit e72082710c
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
library/core/src/main/java/com/google/android/exoplayer2/audio/DefaultAudioSink.java
View file

@ -1702,9 +1702,9 @@ public final class DefaultAudioSink implements AudioSink {
public StreamEventCallbackV29() { public StreamEventCallbackV29() {
handler = new Handler(); handler = new Handler();
// StreamEventCallbackV29 can NOT inherit directly from AudioTrack.StreamEventCallback as it // Avoid StreamEventCallbackV29 inheriting directly from AudioTrack.StreamEventCallback as it
// would cause a NoClassDefFoundError on the first load of DefaultAudioSink for SDK < 29 // would cause a NoClassDefFoundError warning on load of DefaultAudioSink for SDK < 29.
// fatal on some devices. See: https://github.com/google/ExoPlayer/issues/8058 // See: https://github.com/google/ExoPlayer/issues/8058
callback = callback =
new AudioTrack.StreamEventCallback() { new AudioTrack.StreamEventCallback() {
@Override @Override