From e82393ed4108cb34e7b655bad8d098ddafd7652b Mon Sep 17 00:00:00 2001 From: andrewlewis Date: Mon, 22 Jan 2024 02:49:32 -0800 Subject: [PATCH] Skip 1080p test on Nexus 7, API 21 This device doesn't seem to be capable of simultaneous encode/decode at this resolution. We don't have a good way to check the capability (we are already checking separate decode/encode capability) so just skip this test to save time triaging its failures. PiperOrigin-RevId: 600399564 --- .../androidx/media3/transformer/mh/TranscodeQualityTest.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/TranscodeQualityTest.java b/libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/TranscodeQualityTest.java index b28076f0db..abc963893d 100644 --- a/libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/TranscodeQualityTest.java +++ b/libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/TranscodeQualityTest.java @@ -52,9 +52,12 @@ public final class TranscodeQualityTest { /* outputFormat= */ AndroidTestUtil.MP4_ASSET_WITH_INCREASING_TIMESTAMPS_FORMAT)) { return; } + // Skip on specific pre-API 34 devices where calculating SSIM fails. assumeFalse( (Util.SDK_INT < 33 && (Util.MODEL.equals("SM-F711U1") || Util.MODEL.equals("SM-F926U1"))) || (Util.SDK_INT == 33 && Util.MODEL.equals("LE2121"))); + // Skip on specific API 21 devices that aren't able to decode and encode at this resolution. + assumeFalse(Util.SDK_INT == 21 && Util.MODEL.equals("Nexus 7")); Transformer transformer = new Transformer.Builder(context) .setVideoMimeType(MimeTypes.VIDEO_H264)