sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Only log list of removed encoders if not empty.

Browse source 
Logcat had the following lines, with no other information.
```
DefaultEncoderFactory: Encoders removed for resolution:
DefaultEncoderFactory: Encoders removed for bitrate:
DefaultEncoderFactory: Encoders removed for bitrate mode:
```
PiperOrigin-RevId: 511470231
This commit is contained in:
samrobinson 2023-02-22 13:35:27 +00:00 committed by tonihei
parent 9771629498
commit f4d470ac4c
1 changed files with 15 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
libraries/transformer/src/main/java/androidx/media3/transformer/DefaultEncoderFactory.java
View file

@ -630,15 +630,9 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory {
} }
} }
List<MediaCodecInfo> removedEncoders = new ArrayList<>(encoders); if (filteredEncoders.size() != encoders.size()) {
removedEncoders.removeAll(filteredEncoders); logRemovedEncoders(encoders, filteredEncoders, filterName);
StringBuilder stringBuilder =
new StringBuilder("Encoders removed for ").append(filterName).append(":\n");
for (int i = 0; i < removedEncoders.size(); i++) {
MediaCodecInfo encoderInfo = removedEncoders.get(i);
stringBuilder.append(Util.formatInvariant(" %s\n", encoderInfo.getName()));
} }
Log.d(TAG, stringBuilder.toString());
return ImmutableList.copyOf(filteredEncoders); return ImmutableList.copyOf(filteredEncoders);
} }
@ -672,4 +666,17 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory {
/* isDecoder= */ false, /* isDecoder= */ false,
format); format);
} }
private static void logRemovedEncoders(
List<MediaCodecInfo> encoders, List<MediaCodecInfo> filteredEncoders, String filterName) {
List<MediaCodecInfo> removedEncoders = new ArrayList<>(encoders);
removedEncoders.removeAll(filteredEncoders);
StringBuilder stringBuilder =
new StringBuilder("Encoders removed for ").append(filterName).append(":\n");
for (int i = 0; i < removedEncoders.size(); i++) {
MediaCodecInfo encoderInfo = removedEncoders.get(i);
stringBuilder.append(Util.formatInvariant(" %s\n", encoderInfo.getName()));
}
Log.d(TAG, stringBuilder.toString());
}
} }