sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-22 14:05:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
21768 commits 7 branches 40 tags 626 MiB
Commit graph

158 commits

Author SHA1 Message Date
ibaker
636a4a8538 Add javadoc links to README files 
Fix some other link titles and destinations spotted along the way.

#minor-release

PiperOrigin-RevId: 493276172
 2022-12-12 11:19:23 +00:00
ibaker
4f04a284ed Add missing IntDef on MediaSource.Factory.getSupportedTypes overrides 
Without this the annotation isn't shown in javadoc (same in Dackka)

No annotation:
https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/source/DefaultMediaSourceFactory.html#getSupportedTypes()

Annotation present:
https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/source/MediaSource.Factory.html#getSupportedTypes()

#minor-release

PiperOrigin-RevId: 487498450
 2022-11-10 14:56:54 +00:00
ibaker
dbfc0cc770 Fix Dackka/Metalava errors in the HLS and RTSP modules 
This makes two fixes:
1. Remove `HlsSampleStreamWrapper.Callback` (package-private) from the
   list of interfaces implemented by `HlsMediaPeriod` (`public`) and
   move the implementation to a private inner class instead. This avoids
   Metalava complaining about a public class that inherits from a
   package-private type.
2. Reduce the visibility of
   `RtpPayloadFormat.isFormatSupported(MediaDescription)` from `public`
   to package-private. The `MediaDescription` type is already
   package-private, so this method was already unusable outside the
   package.

#minor-release

PiperOrigin-RevId: 487472781
 2022-11-10 14:43:04 +00:00
Rohit Singh
d21c9488df Merge pull request #162 from ittiam-systems:rtp-mp4a-latm 
PiperOrigin-RevId: 482490230
 2022-10-24 10:49:25 +00:00
Rakesh Kumar
ce98d6da84 Fix review comment in CSD parsing of Mp4a-Latm 
Change-Id: I70c412870952e18826f43d218b074b2829127e10
 2022-10-04 17:45:59 +05:30
Rakesh Kumar
0ac84fe16f Fix review comment in mp4a-latm Reader 
Change-Id: I004f4a9ed9bd7cc48708d82a01c945789d1e9e5e
 2022-10-03 17:38:22 +05:30
claincly
b9bcf5224f Fix outdated RtpDataLoadable javadoc 
PiperOrigin-RevId: 469443086
 2022-09-30 16:59:12 +00:00
claincly
a62cf312b7 Handle initial RTSP seek 
PiperOrigin-RevId: 469143613
 2022-09-30 16:55:19 +00:00
Rakesh Kumar
9f8d69929d Fix review comment in CSD parsing of Mp4a-Latm Reader 
Change-Id: I6fc07d88a7dbc52fc2fbe0e5ad45a53f8f25c4fd
 2022-09-30 14:07:27 +05:30
Rakesh Kumar
4880057f92 Fix some more review comment in RTP Mp4a-Latm Reader 
Change-Id: I9033d0bd93c6129c64c41ce70fef26bf8a6e4b6e
 2022-09-30 14:05:53 +05:30
Rakesh Kumar
97afe69e92 Added support for CSD parsing in RTSP Mp4a-Latm Reader 
Added support for parsing CSD data to get sample Rate and Channel
Count.

Change-Id: I69fb0fa2cb11453d3b9e416925d3776eb6dc19a3
 2022-09-21 15:37:29 +05:30
Rakesh Kumar
15f9655e9f Added Rtp Mp4a-Latm Reader Test 
Change-Id: I0054e54183df0bb9370bf3fe7047076e285e1e8f
 2022-09-08 11:22:30 +05:30
Rakesh Kumar
9648529591 Fix review comment in RTP Mp4a-latm Reader 
Change-Id: I7c5c12d86589bdc3f88c336573759bcfb0e7ce1b
 2022-09-08 11:21:13 +05:30
Rakesh Kumar
048aaf34dc Add support for RTSP Mp4a-Latm 
Added Mp4a-latm RTP Packet reader and added support for Mp4a-latm
playback through RTSP.

Change-Id: Ia590393f53ca880af926907843f6bea9ff0f4b35
 2022-09-05 00:04:28 +05:30
claincly
80ec64696e Factor out RTP timestamp to sample time method 
PiperOrigin-RevId: 465337074
 2022-08-04 16:49:03 +00:00
claincly
ed60c885f2 Clean up NOP constructor lines in RTP readers 
PiperOrigin-RevId: 465067191
 2022-08-03 15:51:48 +00:00
tonihei
92816023f1 Merge pull request #115 from ittiam-systems:rtp_vp9fix 
PiperOrigin-RevId: 463852948
 2022-08-08 08:23:56 +00:00
claincly
e848352a3e Fix VP8 reader fragment packet size 
Merging c37a767fdf

PiperOrigin-RevId: 463826373
 2022-08-08 08:21:15 +00:00
tonihei
e54d2f5658 Merge pull request #119 from ittiam-systems:rtp_h263_test_and_fix 
PiperOrigin-RevId: 463146426
 2022-08-08 08:01:44 +00:00
ibaker
2deb435625 Annotate methods that always return this with @CanIgnoreReturnValue 
It's always safe to ignore the result of these methods, because the
caller already has a reference to the returned value.

PiperOrigin-RevId: 462388947
 2022-08-08 07:55:25 +00:00
Manisha Jajoo
ef57a061b7 Pass local copy of input to RtpH263ReaderTest's consume method 
This change is done to keep the frame data unchanged.
RtpH263Reader changes the header data in input, so to send the same
RTP packet across multiple tests, each test copies the frame data
into a new packet and sends that to the reader.
 2022-07-19 11:45:39 +05:30
Manisha Jajoo
c7fbf3437f Revert "Keep the input data constant in consume method" 
This reverts commit 3bacb1646c.
 2022-07-19 11:40:01 +05:30
Manisha Jajoo
69a716f633 fix review comments in RtpH263ReaderTest 2022-07-18 10:44:51 +05:30
Manisha Jajoo
3bacb1646c Keep the input data constant in consume method 
Earlier, the consume method of RtpH263Reader was changing the bytes of the
input bitstream during header parse. This commit copies the input into
local context and changes the local variable as per the specifications
thus keeping the input constant.
 2022-07-18 10:43:41 +05:30
Manisha Jajoo
da47771d10 Add test for Rtp H263 Reader 
Change-Id: I57d57881ef5c158d41be1bf1e3714332d50cd3a9
 2022-07-14 09:36:32 +05:30
claincly
40fd3ffa6c Fix two typos in RtpVp8Reader and test 
PiperOrigin-RevId: 460662425
 2022-07-13 17:43:29 +00:00
Rohit Singh
9d9bbe3d33 Merge pull request #110 from ittiam-systems:rtp_vp8_test 
PiperOrigin-RevId: 460513413
 2022-07-13 17:40:18 +00:00
Manisha Jajoo
a38059d109 Update H263 Reader to handle missing frames/fragments. 
Change-Id: I43dfbabcbe686c31cb54e6b95688af1fa35a3d24
 2022-07-13 17:46:31 +05:30
Manisha Jajoo
db5ff90167 Update VP9 Reader to handle missing frames/fragments. 
Change-Id: I3cdc738b25fda1292ae07769656a3b18721b2402
 2022-07-08 17:14:05 +05:30
Shraddha Basantwani
1de4ee3af5 Add RTP VP8 Reader Test 
Update VP8 Reader to handle missing frames/fragments.

Change-Id: I9eede8f1e3a20fb0ff2e7add0dfc60f0780ec769
 2022-07-06 14:25:14 +05:30
Shraddha Basantwani
ff3d7dff12 Fix VP8 Reader 
Update VP8 header to check if the S bit is set.

Variable fragmentedSampleSizeBytes is initialised with -1, and reader
is directly adding fragmentSize to this variable.
Updated it to check if the size is unset.

Bug: 238153477
Test: manual
Change-Id: I9d5735422a4a0eeb2967af93809b879b434e3c57
 2022-07-06 14:25:14 +05:30
Marc Baechinger
dc0e5c447b Merge pull request #63 from ittiam-systems:rtp-h263 
PiperOrigin-RevId: 455347182
 2022-06-16 11:24:41 +00:00
Rakesh Kumar
fc3c57ecfd
Merge branch 'main' into rtp-h263 2022-06-10 11:38:51 +05:30
Marc Baechinger
58f7ac25a7 Merge pull request #69 from ittiam-systems:rtp_amr_test 
PiperOrigin-RevId: 453905355
 2022-06-09 17:47:15 +00:00
Marc Baechinger
a2a4504329 Merge pull request #53 from ittiam-systems:rtp_opus 
PiperOrigin-RevId: 453490088
 2022-06-09 17:37:09 +00:00
ibaker
26a1817ebf Rollback of e01bb47263 
*** Original commit ***

Rollback of 07302a23bd

*** Original commit ***

Remove `@Nullable` from `MediaSource.Factory` setters

The null-behaviour of these methods creates a minimization footgun,
because **any** call to these setters will prevent R8 from removing
the default implementation (even if it's never used by the app) - this
is because R8 can't tell the default imple...

***

PiperOrigin-RevId: 450453325
 2022-05-23 17:12:22 +01:00
ibaker
1d139174fd Rollback of 07302a23bd 
*** Original commit ***

Remove `@Nullable` from `MediaSource.Factory` setters

The null-behaviour of these methods creates a minimization footgun,
because **any** call to these setters will prevent R8 from removing
the default implementation (even if it's never used by the app) - this
is because R8 can't tell the default implementation is only used if the
parameter is `null`.

PiperOrigin-RevId: 450410833
 2022-05-23 13:01:22 +01:00
ibaker
07302a23bd Remove @Nullable from MediaSource.Factory setters 
The null-behaviour of these methods creates a minimization footgun,
because **any** call to these setters will prevent R8 from removing
the default implementation (even if it's never used by the app) - this
is because R8 can't tell the default implementation is only used if the
parameter is `null`.

PiperOrigin-RevId: 450386627
 2022-05-24 11:07:07 +01:00
Ian Baker
05ce399558 Merge pull request #64 from ittiam-systems:rtp-vp9 
PiperOrigin-RevId: 448978892
 2022-05-24 10:46:15 +01:00
claincly
4c34160a96 Add support for static RTP payload types. 
Some RTP foramts are statically assigned, so they don't have the rtpmap
attribute. Create the missing rtpmap attribute in this case.

PiperOrigin-RevId: 448239724
 2022-05-24 10:38:44 +01:00
Rakesh Kumar
dfc424dbe6 Fix review comment in RTPH263Reader 
Change-Id: I6ae45dc710245769f36130ead4077d8e9980bf54
 2022-05-09 19:13:55 +05:30
Rakesh Kumar
aae9f23c79 Fix some minor review comments in RTPH263Reader 
Change-Id: I0d728c695c9e11c5a50ef6f211bde614df4bbe71
 2022-05-09 19:07:11 +05:30
ibaker
9a67b30750 Migrate usages from C.TYPE_* to C.CONTENT_TYPE_* 
PiperOrigin-RevId: 446156308
 2022-05-09 10:46:04 +01:00
claincly
7af91fc9d5 Ignore mandatory SDP fields as ExoPlayer doesn't use them 
Issue: google/ExoPlayer#10049
PiperOrigin-RevId: 444833508
 2022-05-09 10:20:38 +01:00
Rakesh Kumar
432ae9d38c
Merge branch 'main' into rtp-vp9 2022-05-09 13:27:46 +05:30
Rakesh Kumar
a1cff9af0d Fix review comment in RTPVp9Reader 
Change-Id: I7e2d36eb3d69fb09e0d0bbc283d41165c69d4076
 2022-05-09 13:20:26 +05:30
Rakesh Kumar
f8cd3a9746 Fix some more review comment in RTP H263 Reader. 
Change-Id: If1f80a369b47319251e262c8f171091bb37e90c5
 2022-05-05 15:37:54 +05:30
Rakesh Kumar
ff80a41f90 Fix review comment in RTP H263 Reader 
Change-Id: I987baf379ecf3ba3f387cb38f22646023739addb
 2022-05-05 14:42:19 +05:30
Rakesh Kumar
ffa04ea949
Merge branch 'main' into rtp-h263 2022-05-05 14:36:22 +05:30
claincly
59ced5325c Catch unchecked exception in RtspSessionTiming parsing. 
Issue: google/ExoPlayer#10165
#minor-release
PiperOrigin-RevId: 443653894
 2022-04-26 15:01:29 +01:00
claincly
16b0cee0b6 Fix Basic authentication header 
Issue: google/ExoPlayer#9544

The header must include the word "Basic", but the word is missing.

#minor-release

PiperOrigin-RevId: 443386880
 2022-04-26 14:56:38 +01:00
Shraddha Basantwani
165e706aa9 Add RTP Opus Reader Test 
Change-Id: I189811c9bef9d11e93472c755bc19dee5dc3ee7c
 2022-04-25 15:21:26 +05:30
manisha_jajoo
0bf197341d Add a missing break in RtspMediaTrack and update RtpPayloadFormat.java 2022-04-21 11:59:22 +05:30
Shraddha Basantwani
718cea8d7b Add RTP AMR Reader Test 
Change-Id: Ic8bdffc25b5babf7ccbbb98f161840eb774888e2
 2022-04-21 11:51:27 +05:30
manisha_jajoo
f0d7d96309
Merge branch 'main' into rtp_opus 2022-04-21 10:26:08 +05:30
claincly
e780a32de4 Support colon (:) in RTSP timing. 
Some RTSP servers use `npt`: notation rather than `npt=`

PiperOrigin-RevId: 439333319
 2022-04-06 11:56:55 +01:00
Ian Baker
f48babb4ed Merge pull request #35 from ittiam-systems:rtp-mpeg4 
PiperOrigin-RevId: 438000682
 2022-04-06 11:19:08 +01:00
Ian Baker
e3a9ed6581 Merge pull request #56 from ittiam-systems:rtp_wav 
PiperOrigin-RevId: 437783926
 2022-04-06 11:14:43 +01:00
Ian Baker
9f29d22659 Merge pull request #47 from ittiam-systems:rtp-vp8 
PiperOrigin-RevId: 437710223
 2022-04-06 11:05:54 +01:00
Ian Baker
a11c22b67e Merge pull request #46 from ittiam-systems:rtp_amr 
PiperOrigin-RevId: 437274290
 2022-04-06 11:03:43 +01:00
Rakesh Kumar
3b9519c398 Add support for RTSP VP9 
Change-Id: Id658564495af13c35fa78ecde9ab587557aabb47
 2022-03-31 21:29:32 +05:30
Rakesh Kumar
55bfe71384 Add support for RTSP H263 
Added H263 RTP Packet reader and added support for H263 playback through
RTSP.

Change-Id: I348cc4d8e974b5275409b816a9d52aa29f593233
 2022-03-30 20:31:20 +05:30
Shraddha Basantwani
3f8a68004c Add PCM and G711 Reader Test 
Add RtpPcmReader tests and warning for out of
order packets in RtpPcmReader.

Change-Id: I1554fa0a944dad00248a0a41fefad958da073a21
 2022-03-28 11:27:32 +05:30
Shraddha Basantwani
500c879b8a Modify RtpPcmReader 
Rename a few variable to be more relevant
Add detailed java docs
 2022-03-28 11:22:23 +05:30
Shraddha Basantwani
bfc1fb9aa7 Merge branch 'main' of github.com:ittiam-systems/media into rtp_wav 2022-03-28 11:13:21 +05:30
Manisha Jajoo
3a87039ba1 Fixed review comments in RtpOpusReader 2022-03-24 01:39:10 +05:30
olly
5d8ac644a6 Move TrackGroupArray back to ExoPlayer 
PiperOrigin-RevId: 435325454
 2022-03-17 13:08:56 +00:00
Manisha Jajoo
be108b9e5e Add support for RTSP Opus 
Added Opus RTP packet reader and added support for Opus
playback through RTSP

Change-Id: Ib6702bd8aafd0bd782e89127ab907061ff06ccb3
 2022-03-15 19:09:16 +05:30
Shraddha Basantwani
ac528d3ab0 Add support for RTSP PCM/WAV and G711/WAV 
Added PCM RTP packet reader and added support for PCM 8 bit,
16 bit, ALAW and MULAW playback through RTSP.

Change-Id: If0a187b55faa89850a159e17eae28358d6634799
 2022-03-15 18:51:57 +05:30
olly
2ea902c1b2 Move TrackSelection back to ExoPlayer module 
PiperOrigin-RevId: 433729648
 2022-03-24 17:21:11 +00:00
Manisha Jajoo
1761b423ca Fix review comments in RtpAmrReader 2022-03-09 13:55:58 +05:30
Rakesh Kumar
8afa7a548a Fix review comments in RtpVP8Reader 
Change-Id: Id47c746b199831d0bb51dc736c43fd20c2e79c08
 2022-03-08 16:54:36 +05:30
Rakesh Kumar
f2e0953643 Updated way to create a formatBuilder 
Change-Id: I2c8eb8d6ee28d8c044d71db042f3b186ea5762f3
 2022-03-03 19:59:56 +05:30
Rakesh Kumar
f6a7cceaaf Add support for RTSP VP8 
Added VP8 RTP packet reader and added support for VP8 playback
through RTSP.

Change-Id: Ie22ab79a234f61681cf95886a6ed8104a742f056
 2022-02-24 21:02:41 +05:30
Manisha Jajoo
d1317b60fc Add support for RTSP AMR-NB/WB 
Added AMR-NB/WB RTP packet reader and added support for AMR-NB/WB
playback through RTSP

Change-Id: I0a975fa1e1aa8450bda1c828599a523ba796bc48
 2022-02-23 16:22:07 +05:30
Manisha Jajoo
ef9393a337 Fix review comments on RtpMPEG4Reader 2022-02-21 13:20:12 +05:30
manisha_jajoo
706d5ac252
Merge branch 'main' into rtp-mpeg4 2022-02-21 12:33:09 +05:30
Ian Baker
f3eb6e1376 Merge pull request #36 from ittiam-systems:rtp-h265 
PiperOrigin-RevId: 429566102
 2022-02-18 16:41:12 +00:00
Rakesh Kumar
ca1c1c26d5 Fix some minor review comments in RtpH265Reader 2022-02-15 22:32:06 +05:30
Rakesh Kumar
aa6874655d Add TODO for AggregationPacket mode 2022-02-11 13:46:20 +05:30
Manisha Jajoo
e7567d2072 Fix review comments in RtpMPEG4Reader 2022-02-09 21:36:28 +05:30
Manisha Jajoo
dfef2d1387 Some minor cleanup in RTPMpeg4Reader 2022-02-09 17:23:36 +05:30
Rakesh Kumar
3ef90d9dd4 Fixed some of nitpick for RtpH265Reader 2022-02-09 15:06:16 +05:30
Rakesh Kumar
ace363e183 Fix review comments in RtpH265Reader 2022-02-08 16:41:45 +05:30
tonihei
287182952d Fix the position of IntDefs to match TYPE_USE 
#minor-release

PiperOrigin-RevId: 427131569
 2022-02-08 11:07:50 +00:00
olly
1f7174e731 Revert of 87420e5f9b 
PiperOrigin-RevId: 426996878
 2022-02-08 11:07:43 +00:00
ibaker
87420e5f9b Fix the position of IntDefs to match TYPE_USE 
#minor-release

PiperOrigin-RevId: 426855255
 2022-02-07 10:49:31 +00:00
ibaker
8149ac8922 Mark all non-public IntDefs as only TYPE_USE 
This only changes IntDefs that cannot be used by apps because they're
either private or package-private.

A follow-up change will fix the positions of existing usages to match
this new config.

#minor-release

PiperOrigin-RevId: 426372273
 2022-02-04 14:51:52 +00:00
ibaker
daa45a16bd Fix parameter comments 
PiperOrigin-RevId: 425874534
 2022-02-04 09:32:39 +00:00
olly
cb81b04dab Use ImmutableMap.Builder.buildOrThrow() instead of deprecated build(). 
More info: ​go/immutable-map-buildorthrow-lsc

NOTE: if the source of truth for this code is *NOT* `third_party`, please let me know and I'll revert this CL (and please consider upstreaming this change yourself).

#inlineme

Tested:
    TAP for global presubmit queue passed after automated deflaking of failures: http://mondo/deflaker/run/530857d2-45cb-4069-a234-48c5efe945f1 http://mondo/deflaker/run/0dce4296-e6bb-42d2-8b64-b393f45b6ad3
    http://test/OCL:425453729:BASE:425451020:1643699365244:811c1a24
PiperOrigin-RevId: 425616165
 2022-02-01 18:21:37 +00:00
Manisha Jajoo
743437e34f Clean up RtpMpeg4Reader 2022-01-31 17:31:01 +05:30
Manisha Jajoo
d2f807ebae Add support for RTSP MPEG4 
Added MPEG4 RTP packet reader and added support for MPEG4
playback through RTSP

Change-Id: I57c9a61b18471dbd2c368177ebfb89ee662f995b
 2022-01-28 14:02:28 +05:30
Rakesh Kumar
9cb243647f Clean up RtpH265Reader 2022-01-28 12:25:14 +05:30
claincly
1fe8e07068 Ignore invalid RTP-Info header value. 
Issue: google/ExoPlayer#9619

(and a few other GH issues related to invalid RTP-Info header)

PiperOrigin-RevId: 423283017
 2022-01-25 19:08:54 +00:00
claincly
914cf423bd Handle when RTSP track timing is not available. 
Issue: google/ExoPlayer#9775

We got a few issues for this on GH already. Some RTSP servers do not provide
track timing in PLAY responses, or the timings are invalid.

Missing timing means the RTSP stream is not seekable. Added method to
1. Update the timeline that seek is not possible
2. Report read discontinuity so that playback can start from the beginning.

PiperOrigin-RevId: 423281439
 2022-01-25 19:07:44 +00:00
Rakesh Kumar
4b99db938a Add support for RTSP H265 
Added H265 RTP packet reader and added support for H265
playback through RTSP

Change-Id: Ic0e135768bb92cd3343212c2edd84bae6947320e
 2022-01-18 19:36:22 +05:30
claincly
be99b97a46 Use RTSP server for RTSP auth realm. 
PiperOrigin-RevId: 420053894
 2022-01-11 13:32:41 +00:00
claincly
152a1650f6 Prefers DIGEST when RTSP servers sends both BASIC and DIGEST auth info. 
Issue: google/ExoPlayer#9800

Added test for RTSP authentication.

PiperOrigin-RevId: 420048821
 2022-01-11 13:31:19 +00:00
claincly
1078fffd63 Allow continuous seeking. 
PiperOrigin-RevId: 419629912
 2022-01-05 12:15:35 +00:00
ibaker
34a1f884dc Add MediaSource.Factory and deprecate MediaSourceFactory 
This more closely matches the pattern we have for all implementations
except DefaultMediaSourceFactory (e.g. ProgressiveMediaSource.Factory)
and other factory interfaces like (Http)DataSource.Factory.

PiperOrigin-RevId: 417826803
 2022-01-05 10:51:41 +00:00