mirror of
https://github.com/samsonjs/media.git
synced 2026-04-04 11:05:47 +00:00
0a8ca18305
We currently wait until a previous AudioTrack from the same DefaultAudioSink is released on a background thread before attempting to initialize a new AudioTrack. This is done to avoid issues where the releasing track blocks some shared audio memory, preventing a new track from being created. The current solution has two main shortcomings: - In most cases, the system can easily handle multiple AudioTracks and waiting for the release just causes unnecessary delays (e.g. when seeking). - It only waits for a previous track from the same DefaultAudioSink, not accounting for any other tracks that may be in the process of being released from other players. To improve on both shortcomings, we can (1) move the check for "is releasing tracks and thus may block shared memory" to the static release infrastructure to be shared across all player instances. (2) optimistically create a new AudioTrack immediately without waiting for the previous one to be fully released. (3) extend the existing retry logic that already retries failed attempts for 100ms to only start the timer when ongoing releases are done. This ensures we really waited until we have all shared resources we can get before giving up completely. This also acts as a replacement for change (2) to handle situations where creating a second track is genuinely not possible. Also increase threshold to 200ms as the new unit test is falky on a real device with just 100ms (highlighting that the device needed more than 100ms to clean up internal resources). PiperOrigin-RevId: 654053123 |
||
|---|---|---|
| .. | ||
| cast | ||
| common | ||
| container | ||
| database | ||
| datasource | ||
| datasource_cronet | ||
| datasource_okhttp | ||
| datasource_rtmp | ||
| decoder | ||
| decoder_av1 | ||
| decoder_ffmpeg | ||
| decoder_flac | ||
| decoder_iamf/src | ||
| decoder_midi | ||
| decoder_opus | ||
| decoder_vp9 | ||
| effect | ||
| exoplayer | ||
| exoplayer_dash | ||
| exoplayer_hls | ||
| exoplayer_ima | ||
| exoplayer_rtsp | ||
| exoplayer_smoothstreaming | ||
| exoplayer_workmanager | ||
| extractor | ||
| muxer | ||
| session | ||
| test_data | ||
| test_exoplayer_playback | ||
| test_session_common | ||
| test_session_current | ||
| test_utils | ||
| test_utils_robolectric | ||
| transformer | ||
| ui | ||
| ui_leanback | ||
| lint.xml | ||