sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-03-26 09:35:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
media/libraries
History
ibaker 5612f6924a Fix TextRenderer exception when a subtitle file contains no cues 
Discovered while investigating Issue: google/ExoPlayer#10823

Example stack trace with the previous code (I added the index value for
debugging):

```
playerFailed [eventTime=44.07, mediaPos=44.01, window=0, period=0, errorCode=ERROR_CODE_FAILED_RUNTIME_CHECK
  androidx.media3.exoplayer.ExoPlaybackException: Unexpected runtime error
      at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:635)
      at android.os.Handler.dispatchMessage(Handler.java:102)
      at android.os.Looper.loopOnce(Looper.java:202)
      at android.os.Looper.loop(Looper.java:291)
      at android.os.HandlerThread.run(HandlerThread.java:67)
  Caused by: java.lang.IllegalArgumentException: index=-1
      at androidx.media3.common.util.Assertions.checkArgument(Assertions.java:55)
      at androidx.media3.extractor.text.webvtt.WebvttSubtitle.getEventTime(WebvttSubtitle.java:62)
      at androidx.media3.extractor.text.SubtitleOutputBuffer.getEventTime(SubtitleOutputBuffer.java:56)
      at androidx.media3.exoplayer.text.TextRenderer.getCurrentEventTimeUs(TextRenderer.java:435)
      at androidx.media3.exoplayer.text.TextRenderer.render(TextRenderer.java:268)
      at androidx.media3.exoplayer.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:1008)
      at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:509)
      at android.os.Handler.dispatchMessage(Handler.java:102)
      at android.os.Looper.loopOnce(Looper.java:202)
      at android.os.Looper.loop(Looper.java:291)
      at android.os.HandlerThread.run(HandlerThread.java:67)
]
```

#minor-release

PiperOrigin-RevId: 492464180
(cherry picked from commit 33bbb9511a)
2023-01-25 17:50:39 +00:00
..
cast Bump cast sdk version and remove workaround for live duration 2023-01-25 17:42:21 +00:00
common Removed ExoPlayer specific states from SimpleBasePlayer 2023-01-25 17:50:39 +00:00
database Mark all non-public IntDefs as only TYPE_USE 2022-02-21 16:56:36 +00:00
datasource Fix instrumentation tests not working via Gradle 2022-09-20 15:25:38 +00:00
datasource_cronet Fix instrumentation tests not working via Gradle 2022-09-20 15:25:38 +00:00
datasource_okhttp Annotate methods that always return this with @CanIgnoreReturnValue 2022-07-21 15:24:07 +00:00
datasource_rtmp Annotate methods that always return this with @CanIgnoreReturnValue 2022-07-21 15:24:07 +00:00
decoder Expect PresentationTime Discontinuity During Stream Transitions 2022-04-26 14:21:36 +01:00
decoder_av1 Fix Dackka parameter name error in Gav1Decoder and VpxDecoder 2022-11-10 10:19:01 +00:00
decoder_ffmpeg Add set -eu to all shell scripts 2023-01-25 17:37:31 +00:00
decoder_flac Fix Dackka/Metalava errors in av1, flac, ffmpeg, midi, and opus modules 2022-11-10 10:00:14 +00:00
decoder_opus Add set -eu to all shell scripts 2023-01-25 17:37:31 +00:00
decoder_vp9 Add set -eu to all shell scripts 2023-01-25 17:37:31 +00:00
effect Fix Dackka/Metalava errors in the effects module 2022-11-02 12:21:56 +00:00
exoplayer Fix TextRenderer exception when a subtitle file contains no cues 2023-01-25 17:50:39 +00:00
exoplayer_dash Add missing IntDef on MediaSource.Factory.getSupportedTypes overrides 2022-11-10 12:24:56 +00:00
exoplayer_hls Add missing IntDef on MediaSource.Factory.getSupportedTypes overrides 2022-11-10 12:24:56 +00:00
exoplayer_ima Merge pull request #10799 from OxygenCobalt:id3v2-multi-value 2023-01-25 17:41:39 +00:00
exoplayer_rtsp Add missing IntDef on MediaSource.Factory.getSupportedTypes overrides 2022-11-10 12:24:56 +00:00
exoplayer_smoothstreaming Add missing IntDef on MediaSource.Factory.getSupportedTypes overrides 2022-11-10 12:24:56 +00:00
exoplayer_workmanager Reformat some javadoc 2022-02-18 14:54:02 +00:00
extractor Split SubripDecoder and ParsableByteArray tests 2023-01-25 17:50:39 +00:00
session Write media type with a custom key to legacy components. 2023-01-25 17:50:39 +00:00
test_data Merge pull request #10750 from Stronger197:subrip_utf_16 2023-01-25 17:50:39 +00:00
test_exoplayer_playback Fix instrumentation tests not working via Gradle 2022-09-20 15:25:38 +00:00
test_session_common Migrate BROWSER_ROOT_HINTS_KEY_ROOT_CHILDREN_SUPPORTED_FLAGS to Media3 2023-01-25 17:38:34 +00:00
test_session_current Write media type with a custom key to legacy components. 2023-01-25 17:50:39 +00:00
test_utils Ensure messages sent on a dead thread don't block FakeClock execution 2023-01-25 17:41:00 +00:00
test_utils_robolectric Remove flakiness from DefaultAnalyticsCollectorTest 2023-01-25 17:41:00 +00:00
transformer HDR: Implement ForceInterpretHdrVideoAsSdr 2022-11-09 20:05:24 +00:00
ui Mark broadcast receivers as not exported 2023-01-25 17:37:31 +00:00
ui_leanback Listen to playWhenReady changes in LeanbackPlayerAdapter 2022-07-11 15:49:33 +00:00