mirror of
https://github.com/samsonjs/media.git
synced 2026-03-31 10:25:48 +00:00
93b3f43ed2
Fix Matroska, Heif, FLAC, Ogg, Opus, Vorbis extractor nullness check. There should be no functional change. Every media that fail to be parsed should still fail. Every media that parsed successfully should still succeed. This refactor aims to push all nullness constraints up the call stack to clarify each API nullness contract. This ensures implementation and caller have to prove their respective contract close to where such logic is implemented. This also allows to fail early if an nullness contract is broken instead of deep in the call stack. For example, by adding a requirement that all implementation of `StreamReader.readHeaders` have to initialize `setupData.format` if the return false, each overriding method is forced to prove this next to the logic initializing it. This also means the runtime check might not be needed because the nullnessChecker can prove itself the contract holds. This is in contrast with adding a null check at the point of usage, which will not catch logic errors where they are produce, but later when they are perceived; making it harder to debug and catching the issue at run time instead of compile time. #exofixit PiperOrigin-RevId: 346163124 |
||
|---|---|---|
| .. | ||
| all | ||
| common | ||
| core | ||
| dash | ||
| extractor | ||
| hls | ||
| smoothstreaming | ||
| ui | ||
| README.md | ||
ExoPlayer library
The ExoPlayer library is split into multiple modules. See ExoPlayer's top level README for more information about the available library modules and how to use them.