sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-03-26 09:35:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
media/library
History
ibaker fff7b8079a Replace Util.toUpperInvariant() with Ascii.toUpperCase() 
Even when fixed to the US locale (and thus avoiding surprising behaviour
in e.g. Turkish locale with "i" and "I") there are unexpected behaviours
when upper and lower casing non-ASCII characters.

For example it's sometimes not symmetric, e.g.:
"ẞ".toLowerCase() -> "ß"
"ß".toUpperCase() -> "SS"

In all the ExoPlayer usages we are either dealing with known-ASCII
strings (e.g. MIME types) or comparing against ASCII constant strings
anyway, so it seems easier to just use Guava's ASCII-only class in these
cases.

Util.toUpperInvariant() is null-tolerant, while Ascii.toLowercase() is
not. Most usages in this change are clearly non-null. The BandwidthMeter
usages aren't annotated @Nullable, but the current code *would* work if
countryCode was null in both cases. These methods will now throw NPE if
they're passed null.

PiperOrigin-RevId: 368816287
2021-04-16 14:13:08 +01:00
..
all Add Transformer "Getting started" page 2021-02-03 15:03:16 +00:00
common Replace Util.toUpperInvariant() with Ascii.toUpperCase() 2021-04-16 14:13:08 +01:00
core Replace Util.toUpperInvariant() with Ascii.toUpperCase() 2021-04-16 14:13:08 +01:00
dash Replace Util.toLowerInvariant() with Ascii.toLowerCase() 2021-04-15 10:51:48 +01:00
extractor Update internal codebase location for flac extension 2021-04-14 11:42:51 +01:00
hls Replace Util.toUpperInvariant() with Ascii.toUpperCase() 2021-04-16 14:13:08 +01:00
smoothstreaming Add common prefix to loader thread names 2021-02-11 12:05:06 +00:00
transformer SampleStream/SampleQueue: Introduce read flags 2021-03-24 18:03:28 +00:00
ui Merge pull request #8814 from dlafayet:line-height 2021-04-16 14:12:46 +01:00
README.md Tweak and add READMEs + remove refs to V1 2017-08-17 22:59:34 +01:00

README.md

ExoPlayer library

The ExoPlayer library is split into multiple modules. See ExoPlayer's top level README for more information about the available library modules and how to use them.