From 64480c987966d387340119bc953a40b11f6e7bb1 Mon Sep 17 00:00:00 2001
From: Richie Bendall <richiebendall@gmail.com>
Date: Wed, 18 Mar 2020 18:17:07 +1300
Subject: [PATCH] refactor: Rewrite tests

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
---
 package.json |   3 +++
 test.js      |  66 +++++++++++++++++++++++++++++----------------------
 yarn.lock    | Bin 183012 -> 184394 bytes
 3 files changed, 41 insertions(+), 28 deletions(-)

diff --git a/package.json b/package.json
index 9ffbd509..d317b635 100644
--- a/package.json
+++ b/package.json
@@ -43,9 +43,12 @@
   },
   "devDependencies": {
     "css": "^2.2.4",
+    "file-ext": "^1.0.0",
+    "get-ext": "^1.0.2",
     "has-flag": "^4.0.0",
     "husky": "^4.2.1",
     "nodemon": "^2.0.2",
+    "path-extra": "^4.3.0",
     "standard": "^14.3.1"
   },
   "resolutions": {
diff --git a/test.js b/test.js
index 9593a3c2..ceb01390 100644
--- a/test.js
+++ b/test.js
@@ -1,45 +1,54 @@
-const path = require('path')
 const fs = require('fs-extra')
 const CSS = require('css')
 const { validDomainId } = require('./routes/utils')
 const hasFlag = require('has-flag')
+const getExtension = require('file-ext')
+const path = require('path-extra')
+const is = require('@sindresorhus/is')
 
-function report (content, fix) {
+async function report (content, fix) {
   console.error(content)
-  if (fix && hasFlag('--fix')) fix()
+  if (fix && hasFlag('--fix')) await fix()
   process.exitCode = 1
 }
 
 (async () => {
   const users = await fs.readdir('users')
-  users.forEach(async user => {
-    if (!user.endsWith('json')) {
-      report(`${user} is not a json file`, () =>
-        fs.unlink(path.join('users', user), () => { })
-      )
+
+  for (const user of users) {
+    if (getExtension(user) !== 'json') {
+      await report(`${user} is not a json file`, async () => {
+        await fs.remove(user)
+      })
     }
-    if (!validDomainId(user.replace('.json', ''))) {
-      report(`${user} is not a valid domain id.`)
+
+    if (!validDomainId(path.base(user))) {
+      await report(`${user} is not a valid domain id.`)
     }
+
     try {
       const data = await fs.readFile(path.join('users', user), 'utf8')
+
       try {
-        const u = JSON.parse(data)
-        if (!u.locked && !u.copyright) {
+        const parsedData = JSON.parse(data)
+
+        if (!parsedData.locked && !parsedData.copyright) {
           report(`Copyright not specified in ${user}`)
         }
-        if (u.version) {
-          report(`Version tag found in ${user}`, () => {
-            delete u.version
-            const stringified = `${JSON.stringify(u, 0, 2)}\n`
-            fs.writeFile(path.join('users', user), stringified, () => { })
+
+        if (parsedData.version) {
+          await report(`Version tag found in ${user}`, async () => {
+            delete parsedData.version
+            const stringified = `${JSON.stringify(parsedData, 0, 2)}\n`
+            await fs.writeFile(path.join('users', user), stringified)
           })
         }
-        if (typeof u.gravatar === 'string') {
-          report(`Gravatar boolean encoded as string found in ${user}`, () => {
-            u.gravatar = u.gravatar === 'true'
-            const stringified = `${JSON.stringify(u, 0, 2)}\n`
-            fs.writeFile(path.join('users', user), stringified, () => { })
+
+        if (is.string(parsedData.gravatar)) {
+          await report(`Gravatar boolean encoded as string found in ${user}`, async () => {
+            parsedData.gravatar = parsedData.gravatar === 'true'
+            const stringified = `${JSON.stringify(parsedData, 0, 2)}\n`
+            await fs.writeFile(path.join('users', user), stringified)
           })
         }
       } catch ({ message }) {
@@ -48,15 +57,16 @@ function report (content, fix) {
     } catch ({ message }) {
       report(`Unable to read ${user} (${message})`)
     }
-  })
+  }
 
   const themes = await fs.readdir('themes')
-  await themes.forEach(async theme => {
-    if (theme.endsWith('css')) {
+
+  for (const theme of themes) {
+    if (getExtension(theme) === 'css') {
       try {
-        const data = await fs.readFile(path.join('themes', theme), 'utf8')
+        const cssData = await fs.readFile(path.join('themes', theme), 'utf8')
         try {
-          CSS.parse(data)
+          CSS.parse(cssData)
         } catch ({ message }) {
           report(`Invalid CSS in ${theme} (${message})`)
         }
@@ -64,5 +74,5 @@ function report (content, fix) {
         report(`Unable to read ${theme} (${message})`)
       }
     }
-  })
+  }
 })()
diff --git a/yarn.lock b/yarn.lock
index c5371bd77d6a35b1b8285911c29f349f8edb139a..9841028ba197644b4aeecccf0439d17557b426bf 100644
GIT binary patch
delta 965
zcmY+DJ#X7a7{?*QK>?>rkk)mY42C+YlJ3ZRAp;b#6pMOcNxejoEe!_vawk%vMTvT$
zsLfxYY@n$~va~}x6z$-l=-8!0;Px|QX}WglR#NfOyXATAxdZ;c=lS2;7k7Vub@#`g
z-tFhvda;FW=Jcz-_seNg%on-qu{6xX0!a2^xcN+g0_Fx`0_C<WK#UBGkYoZGa?7?2
z4w8r%n8o+L{^XfWbydC8jUnsi%n*CIVpUm(^_I2rn;>8$(kOJywHGcNn=SRG$A(?K
zsB~zxH-dvfTPbxzzgOCT2{M4~U51-peD&?o@sKT2S;yInRG5%GI8K%yCOIfTQUE`H
z|L%vwJIRfci|y5D?=b%6&ga`#nauu^_guH{cUZy>i(5>Ri480ZSvG-~S&UjxGypSg
zj2XcK1pt${^!lTR#in}(w6zAE^Es9(<TQXi>@~vj8Mtm`GB194=!Yk_N**WDRxFsi
z{^U5Dii>Ca`Nw{kG}jOF@73-ESU@HgHyM*SLx^HZfh=QLN^*c000I}dCCYII9zLHo
zO5<k5>~!hMX$-t^q)v-LTkW8JTb#{oHYQxuCN*tNwN6>R#2r4Ek*fRUWTth@HtTmo
zM^nz{U1b?Lr-8C;Epw5wovC{d9z|1@=WL#~78Ilc%pM#}^W2>no)_)haV`9sd2|26
zq>q7da)AnB0mO@&FSaK)nGc>OX9?KUSUBl;0wcex@A!}eEQ85JvWP5kN@WY#rYy<`
z3EUJ+iNa(6qJ-l=s)yZ8pZTkG(3FF<T5AY&tc(=NS0_4pP9sFbK02$>)>AR8;p(Q+
z>e=U_Fc6F=61`BXYl2%<$1`%iTyplTV|v4yK5^pLzkM3F{(5wjdL>{}&#-phzBLiZ
zUjKWO`RC1pls=ta0{{Qv#aDk8xA5iO5lBiqCLl8b$%#XlgrO~(kRizy65oL2Par}l
zht!lrJHER2aWBE$)Hk!$Xfbp(9E5O;gGy~tF6ru}y|kTbRIV5!9Y9`*9HUfs=Dw;&
kB%-;xE{k<ORTg1ic4safpXSz~>a^#2qx9X|mwUPY0Q9jlegFUf

delta 73
zcmV-P0Ji_ipbO-c3$U{41a4t%WtSgT0v?x-M*%FeH|$pyw@w2Aj=KqPEoNzMVQg%9
fmqAVe7?(h60W7ydzyZz^w_?=+?asGTr2_XVK%pI=