Add a seperate cache-store proxy for the redis gem

While a cache-store proxy exists for the redis-store gem, no such proxy
existed for using the redis gem itself. This fills that gap by adding
such a proxy.

Resolves kickstarter/rack-attack#190
This commit is contained in:
Brad Lindsay 2018-02-06 09:33:02 -06:00
parent 39c04b311f
commit 0f6ef47683
4 changed files with 49 additions and 3 deletions

View file

@ -13,6 +13,7 @@ class Rack::Attack
autoload :DalliProxy, 'rack/attack/store_proxy/dalli_proxy'
autoload :MemCacheProxy, 'rack/attack/store_proxy/mem_cache_proxy'
autoload :RedisStoreProxy, 'rack/attack/store_proxy/redis_store_proxy'
autoload :RedisProxy, 'rack/attack/store_proxy/redis_proxy'
autoload :Fail2Ban, 'rack/attack/fail2ban'
autoload :Allow2Ban, 'rack/attack/allow2ban'
autoload :Request, 'rack/attack/request'

View file

@ -1,10 +1,10 @@
module Rack
class Attack
module StoreProxy
PROXIES = [DalliProxy, MemCacheProxy, RedisStoreProxy].freeze
PROXIES = [DalliProxy, MemCacheProxy, RedisStoreProxy, RedisProxy].freeze
ACTIVE_SUPPORT_WRAPPER_CLASSES = Set.new(['ActiveSupport::Cache::MemCacheStore', 'ActiveSupport::Cache::RedisStore']).freeze
ACTIVE_SUPPORT_CLIENTS = Set.new(['Redis::Store', 'Dalli::Client', 'MemCache']).freeze
ACTIVE_SUPPORT_CLIENTS = Set.new(['Redis::Store', 'Redis', 'Dalli::Client', 'MemCache']).freeze
def self.build(store)
client = unwrap_active_support_stores(store)

View file

@ -0,0 +1,44 @@
require 'delegate'
module Rack
class Attack
module StoreProxy
class RedisProxy < SimpleDelegator
def self.handle?(store)
defined?(::Redis) && store.is_a?(::Redis)
end
def initialize(store)
super(store)
end
def read(key)
get(key)
end
def write(key, value, options={})
if (expires_in = options[:expires_in])
setex(key, expires_in, value)
else
set(key, value)
end
end
def increment(key, amount, options={})
count = nil
pipelined do
count = incrby(key, amount)
expire(key, options[:expires_in]) if options[:expires_in]
end
count.value if count
end
def delete(key, options={})
del(key)
end
end
end
end
end

View file

@ -27,7 +27,8 @@ describe Rack::Attack::Cache do
ActiveSupport::Cache::MemCacheStore.new("127.0.0.1"),
Dalli::Client.new,
ConnectionPool.new { Dalli::Client.new },
Redis::Store.new
Redis::Store.new,
Redis.new
]
cache_stores.each do |store|