From 0fbfda0146836cc9fc0f8e191230aff49cbbedf7 Mon Sep 17 00:00:00 2001 From: thomas morgan Date: Wed, 20 Oct 2021 10:18:33 -0600 Subject: [PATCH] test against dalli 3.0 --- .github/workflows/build.yml | 3 +-- Appraisals | 6 +++++- gemfiles/connection_pool_dalli.gemfile | 2 +- gemfiles/dalli3.gemfile | 7 +++++++ spec/acceptance/stores/active_support_dalli_store_spec.rb | 6 +++++- 5 files changed, 19 insertions(+), 5 deletions(-) create mode 100644 gemfiles/dalli3.gemfile diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d7ebc13..2c33c80 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -28,6 +28,7 @@ jobs: - rails_6_0 - rails_5_2 - rails_4_2 + - dalli3 - dalli2 - redis_4 - redis_3 @@ -45,8 +46,6 @@ jobs: ruby: 3.0.2 - gemfile: dalli2 ruby: 3.0.2 - - gemfile: connection_pool_dalli - ruby: 3.0.2 - gemfile: rack_1 ruby: 2.7.4 - gemfile: rails_4_2 diff --git a/Appraisals b/Appraisals index 03c6a70..3b546fb 100644 --- a/Appraisals +++ b/Appraisals @@ -41,6 +41,10 @@ appraise 'dalli2' do gem 'dalli', '~> 2.0' end +appraise 'dalli3' do + gem 'dalli', '~> 3.0' +end + appraise 'redis_4' do gem 'redis', '~> 4.0' end @@ -51,7 +55,7 @@ end appraise "connection_pool_dalli" do gem "connection_pool", "~> 2.2" - gem "dalli", "~> 2.7" + gem "dalli", "~> 3.0" end appraise "active_support_redis_cache_store" do diff --git a/gemfiles/connection_pool_dalli.gemfile b/gemfiles/connection_pool_dalli.gemfile index 69dc887..67c69a5 100644 --- a/gemfiles/connection_pool_dalli.gemfile +++ b/gemfiles/connection_pool_dalli.gemfile @@ -3,6 +3,6 @@ source "https://rubygems.org" gem "connection_pool", "~> 2.2" -gem "dalli", "~> 2.7" +gem "dalli", "~> 3.0" gemspec path: "../" diff --git a/gemfiles/dalli3.gemfile b/gemfiles/dalli3.gemfile new file mode 100644 index 0000000..5f4d073 --- /dev/null +++ b/gemfiles/dalli3.gemfile @@ -0,0 +1,7 @@ +# This file was generated by Appraisal + +source "https://rubygems.org" + +gem "dalli", "~> 3.0" + +gemspec path: "../" diff --git a/spec/acceptance/stores/active_support_dalli_store_spec.rb b/spec/acceptance/stores/active_support_dalli_store_spec.rb index 5896443..7035516 100644 --- a/spec/acceptance/stores/active_support_dalli_store_spec.rb +++ b/spec/acceptance/stores/active_support_dalli_store_spec.rb @@ -2,7 +2,11 @@ require_relative "../../spec_helper" -if defined?(::Dalli) +should_run = + defined?(::Dalli) && + Gem::Version.new(::Dalli::VERSION) < Gem::Version.new("3") + +if should_run require_relative "../../support/cache_store_helper" require "active_support/cache/dalli_store" require "timecop"