sjs/rack-attack
1
0
Fork 0
mirror of https://github.com/samsonjs/rack-attack.git synced 2026-04-27 15:07:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix edge case, if maxretry is 1, let them get 1 request in

Browse source
This commit is contained in:
Jordan Moncharmont 2013-09-27 17:35:01 -07:00
parent ef59c5182a
commit 273e045f10
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/rack/attack/allow2ban.rb
View file

@ -13,12 +13,11 @@ module Rack
count = cache.count("#{key_prefix}:count:#{discriminator}", findtime) count = cache.count("#{key_prefix}:count:#{discriminator}", findtime)
if count >= maxretry if count >= maxretry
ban!(discriminator, bantime) ban!(discriminator, bantime)
true end
else # we may not block them this time, but they're banned for next time
false false
end end
end end
end end
end end
end end
end

4
spec/allow2ban_spec.rb
View file

@ -45,8 +45,8 @@ describe 'Rack::Attack.Allow2Ban' do
get '/?foo=OMGHAX', {}, 'REMOTE_ADDR' => '1.2.3.4' get '/?foo=OMGHAX', {}, 'REMOTE_ADDR' => '1.2.3.4'
end end
it 'fails' do it 'succeeds' do
last_response.status.must_equal 401 last_response.status.must_equal 200
end end
it 'increases fail count' do it 'increases fail count' do