From 29424fb993760e5820579d754ec14f3017775fec Mon Sep 17 00:00:00 2001 From: Gonzalo Rodriguez Date: Tue, 17 Apr 2018 14:01:07 -0400 Subject: [PATCH] Enable Gemspec rubocop cops Run rubocop against oldest supported ruby --- .rubocop.yml | 5 +++++ rack-attack.gemspec | 19 ++++++++++--------- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 2f136cb..91492ab 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,7 +1,12 @@ AllCops: + TargetRubyVersion: 2.2 DisabledByDefault: true Bundler: Enabled: true + +Gemspec: + Enabled: true + Layout: Enabled: true diff --git a/rack-attack.gemspec b/rack-attack.gemspec index 6803d0a..85aa1c6 100644 --- a/rack-attack.gemspec +++ b/rack-attack.gemspec @@ -21,24 +21,25 @@ Gem::Specification.new do |s| s.summary = %q{Block & throttle abusive requests} s.test_files = Dir.glob("spec/**/*") - s.required_ruby_version = '>= 2.0.0' + s.required_ruby_version = '>= 2.2' s.add_dependency 'rack' + s.add_development_dependency 'actionpack', '>= 3.0.0' + s.add_development_dependency 'activesupport', '>= 3.0.0' + s.add_development_dependency 'appraisal' + s.add_development_dependency 'connection_pool' + s.add_development_dependency 'dalli' + s.add_development_dependency 'guard-minitest' + s.add_development_dependency 'memcache-client' s.add_development_dependency 'minitest' s.add_development_dependency "minitest-stub-const" + s.add_development_dependency 'pry' s.add_development_dependency 'rack-test' s.add_development_dependency 'rake' - s.add_development_dependency 'appraisal' - s.add_development_dependency 'activesupport', '>= 3.0.0' - s.add_development_dependency 'actionpack', '>= 3.0.0' s.add_development_dependency 'redis-activesupport' - s.add_development_dependency 'dalli' - s.add_development_dependency 'connection_pool' - s.add_development_dependency 'memcache-client' s.add_development_dependency "timecop" - s.add_development_dependency 'pry' - s.add_development_dependency 'guard-minitest' + # Need to explicitly depend on guard because guard-minitest doesn't declare # the dependency intentionally #