From 569ecec7c7e36e3dec319925b49eae5bc706142c Mon Sep 17 00:00:00 2001
From: Gonzalo Rodriguez <grzuy0@gmail.com>
Date: Tue, 13 Mar 2018 14:19:22 -0300
Subject: [PATCH 1/3] Acceptance test Rack::Attack#track

---
 spec/acceptance/track_spec.rb | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 spec/acceptance/track_spec.rb

diff --git a/spec/acceptance/track_spec.rb b/spec/acceptance/track_spec.rb
new file mode 100644
index 0000000..7f4b393
--- /dev/null
+++ b/spec/acceptance/track_spec.rb
@@ -0,0 +1,27 @@
+require_relative "../spec_helper"
+
+describe "#track" do
+  it "notifies when track block returns true" do
+    Rack::Attack.track("ip 1.2.3.4") do |request|
+      request.ip == "1.2.3.4"
+    end
+
+    notification_matched = nil
+    notification_type = nil
+
+    ActiveSupport::Notifications.subscribe("rack.attack") do |_name, _start, _finish, _id, request|
+      notification_matched = request.env["rack.attack.matched"]
+      notification_type = request.env["rack.attack.match_type"]
+    end
+
+    get "/", {}, "REMOTE_ADDR" => "5.6.7.8"
+
+    assert_nil notification_matched
+    assert_nil notification_type
+
+    get "/", {}, "REMOTE_ADDR" => "1.2.3.4"
+
+    assert_equal "ip 1.2.3.4", notification_matched
+    assert_equal :track, notification_type
+  end
+end

From 066434973f88963b5c3ed4ba14eb2dd39af20d7c Mon Sep 17 00:00:00 2001
From: Gonzalo Rodriguez <grzuy0@gmail.com>
Date: Tue, 13 Mar 2018 14:43:37 -0300
Subject: [PATCH 2/3] Acceptance test Rack::Attack#track for throttle

---
 spec/acceptance/track_throttle_spec.rb | 45 ++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 spec/acceptance/track_throttle_spec.rb

diff --git a/spec/acceptance/track_throttle_spec.rb b/spec/acceptance/track_throttle_spec.rb
new file mode 100644
index 0000000..900f843
--- /dev/null
+++ b/spec/acceptance/track_throttle_spec.rb
@@ -0,0 +1,45 @@
+require_relative "../spec_helper"
+require "timecop"
+
+describe "#track with throttle-ish options" do
+  it "notifies when throttle goes over the limit" do
+    Rack::Attack.cache.store = ActiveSupport::Cache::MemoryStore.new
+
+    Rack::Attack.track("by ip", limit: 1, period: 60) do |request|
+      request.ip
+    end
+
+    notification_matched = nil
+    notification_type = nil
+
+    ActiveSupport::Notifications.subscribe("rack.attack") do |_name, _start, _finish, _id, request|
+      notification_matched = request.env["rack.attack.matched"]
+      notification_type = request.env["rack.attack.match_type"]
+    end
+
+    get "/", {}, "REMOTE_ADDR" => "1.2.3.4"
+
+    assert_nil notification_matched
+    assert_nil notification_type
+
+    get "/", {}, "REMOTE_ADDR" => "5.6.7.8"
+
+    assert_nil notification_matched
+    assert_nil notification_type
+
+    get "/", {}, "REMOTE_ADDR" => "1.2.3.4"
+
+    assert_equal "by ip", notification_matched
+    assert_equal :track, notification_type
+
+    Timecop.travel(60) do
+      notification_matched = nil
+      notification_type = nil
+
+      get "/", {}, "REMOTE_ADDR" => "1.2.3.4"
+
+      assert_nil notification_matched
+      assert_nil notification_type
+    end
+  end
+end

From 564cbedb36693e026a981512197e9e0702c152e0 Mon Sep 17 00:00:00 2001
From: Gonzalo Rodriguez <grzuy0@gmail.com>
Date: Tue, 13 Mar 2018 18:27:19 -0300
Subject: [PATCH 3/3] Acceptance test that tracking throttles doesn't actually
 throttle requests

---
 spec/acceptance/track_throttle_spec.rb | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/spec/acceptance/track_throttle_spec.rb b/spec/acceptance/track_throttle_spec.rb
index 900f843..7446ce4 100644
--- a/spec/acceptance/track_throttle_spec.rb
+++ b/spec/acceptance/track_throttle_spec.rb
@@ -2,7 +2,7 @@ require_relative "../spec_helper"
 require "timecop"
 
 describe "#track with throttle-ish options" do
-  it "notifies when throttle goes over the limit" do
+  it "notifies when throttle goes over the limit without actually throttling requests" do
     Rack::Attack.cache.store = ActiveSupport::Cache::MemoryStore.new
 
     Rack::Attack.track("by ip", limit: 1, period: 60) do |request|
@@ -22,16 +22,22 @@ describe "#track with throttle-ish options" do
     assert_nil notification_matched
     assert_nil notification_type
 
+    assert_equal 200, last_response.status
+
     get "/", {}, "REMOTE_ADDR" => "5.6.7.8"
 
     assert_nil notification_matched
     assert_nil notification_type
 
+    assert_equal 200, last_response.status
+
     get "/", {}, "REMOTE_ADDR" => "1.2.3.4"
 
     assert_equal "by ip", notification_matched
     assert_equal :track, notification_type
 
+    assert_equal 200, last_response.status
+
     Timecop.travel(60) do
       notification_matched = nil
       notification_type = nil
@@ -40,6 +46,8 @@ describe "#track with throttle-ish options" do
 
       assert_nil notification_matched
       assert_nil notification_type
+
+      assert_equal 200, last_response.status
     end
   end
 end