sjs/rack-attack
1
0
Fork 0
mirror of https://github.com/samsonjs/rack-attack.git synced 2026-04-01 10:35:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Fixes #355] Avoid unexpected 'Gem::LoadError' for redis when not intented to be used

Browse source 
It seems that the original implementation accidentally autoloaded ActiveSupport::Cache::RedisCacheStore
which once evaluated asks for redis v4 generating Gem::LoadError.

In order to bypass any unnecessary constant autoloading we can just check class name string.
This commit is contained in:
Gonzalo Rodriguez 2018-09-30 22:11:16 -03:00
parent 82c0a17dd4
commit 935f99a638
No known key found for this signature in database
GPG key ID: 5DB8B81B049B8AB1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/rack/attack/store_proxy/redis_cache_store_proxy.rb
View file

@ -7,7 +7,7 @@ module Rack
module StoreProxy
class RedisCacheStoreProxy < SimpleDelegator
def self.handle?(store)
defined?(::Redis) && defined?(::ActiveSupport::Cache::RedisCacheStore) && store.is_a?(::ActiveSupport::Cache::RedisCacheStore)
store.class.name == "ActiveSupport::Cache::RedisCacheStore"
end
def increment(name, amount = 1, options = {})