sjs/rack-attack
1
0
Fork 0
mirror of https://github.com/samsonjs/rack-attack.git synced 2026-04-25 14:47:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Enforce every rack-attack contributor runs same rubocop version

Browse source
This commit is contained in:
Gonzalo Rodriguez 2018-04-17 15:59:46 -04:00
parent 9faf6cd32b
commit d01c3e61d4
No known key found for this signature in database
GPG key ID: 5DB8B81B049B8AB1
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CONTRIBUTING.md
View file

@ -20,7 +20,7 @@ Any of the following is greatly appreciated:
As an effort to keep the codebase consistent, we encourage the use of [Rubocop](https://github.com/bbatsov/rubocop). As an effort to keep the codebase consistent, we encourage the use of [Rubocop](https://github.com/bbatsov/rubocop).
This tool helps us abstract most of the decisions we have to make when coding. This tool helps us abstract most of the decisions we have to make when coding.
To check your code, simply type `rubocop` in the shell. The resulting output are all the offenses currently present in the code. To check your code, simply type `bundle exec rubocop` in the shell. The resulting output are all the offenses currently present in the code.
It is highly recommended that you integrate a linter with your editor. It is highly recommended that you integrate a linter with your editor.
This way you receive real time feedback about your code. Most editors have some kind of plugin for that. This way you receive real time feedback about your code. Most editors have some kind of plugin for that.

1
rack-attack.gemspec
View file

@ -38,6 +38,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'rack-test' s.add_development_dependency 'rack-test'
s.add_development_dependency 'rake' s.add_development_dependency 'rake'
s.add_development_dependency 'redis-activesupport' s.add_development_dependency 'redis-activesupport'
s.add_development_dependency "rubocop", "0.55.0"
s.add_development_dependency "timecop" s.add_development_dependency "timecop"
# Need to explicitly depend on guard because guard-minitest doesn't declare # Need to explicitly depend on guard because guard-minitest doesn't declare