From e6854bcb023169030cdbf3c6d6ad89e68dcdad3e Mon Sep 17 00:00:00 2001 From: Gonzalo Rodriguez Date: Tue, 19 Jun 2018 17:36:21 -0300 Subject: [PATCH] Enable rubocop Naming cops --- .rubocop.yml | 5 +++++ lib/rack/attack.rb | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index ed37697..5ca4365 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -16,6 +16,11 @@ Layout: Lint: Enabled: true +Naming: + Enabled: true + Exclude: + - "lib/rack/attack/path_normalizer.rb" + Performance: Enabled: true diff --git a/lib/rack/attack.rb b/lib/rack/attack.rb index 1140f91..4a96778 100644 --- a/lib/rack/attack.rb +++ b/lib/rack/attack.rb @@ -38,15 +38,15 @@ class Rack::Attack self.blocklists[name] = Blocklist.new(name, block) end - def blocklist_ip(ip) + def blocklist_ip(ip_address) @ip_blocklists ||= [] - ip_blocklist_proc = lambda { |request| IPAddr.new(ip).include?(IPAddr.new(request.ip)) } + ip_blocklist_proc = lambda { |request| IPAddr.new(ip_address).include?(IPAddr.new(request.ip)) } @ip_blocklists << Blocklist.new(nil, ip_blocklist_proc) end - def safelist_ip(ip) + def safelist_ip(ip_address) @ip_safelists ||= [] - ip_safelist_proc = lambda { |request| IPAddr.new(ip).include?(IPAddr.new(request.ip)) } + ip_safelist_proc = lambda { |request| IPAddr.new(ip_address).include?(IPAddr.new(request.ip)) } @ip_safelists << Safelist.new(nil, ip_safelist_proc) end