From fcb89a6c12a129d7298b0234f42ae03e11e912bf Mon Sep 17 00:00:00 2001 From: Gonzalo Rodriguez Date: Fri, 1 Mar 2019 22:22:11 -0300 Subject: [PATCH] refactor: avoid unnecessary nil argument passing --- lib/rack/attack.rb | 4 ++-- lib/rack/attack/blocklist.rb | 2 +- lib/rack/attack/safelist.rb | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/rack/attack.rb b/lib/rack/attack.rb index 26b6725..8066622 100644 --- a/lib/rack/attack.rb +++ b/lib/rack/attack.rb @@ -50,11 +50,11 @@ class Rack::Attack end def blocklist_ip(ip_address) - anonymous_blocklists << Blocklist.new(nil) { |request| IPAddr.new(ip_address).include?(IPAddr.new(request.ip)) } + anonymous_blocklists << Blocklist.new { |request| IPAddr.new(ip_address).include?(IPAddr.new(request.ip)) } end def safelist_ip(ip_address) - anonymous_safelists << Safelist.new(nil) { |request| IPAddr.new(ip_address).include?(IPAddr.new(request.ip)) } + anonymous_safelists << Safelist.new { |request| IPAddr.new(ip_address).include?(IPAddr.new(request.ip)) } end def throttle(name, options, &block) diff --git a/lib/rack/attack/blocklist.rb b/lib/rack/attack/blocklist.rb index bd7fa11..08adcc6 100644 --- a/lib/rack/attack/blocklist.rb +++ b/lib/rack/attack/blocklist.rb @@ -3,7 +3,7 @@ module Rack class Attack class Blocklist < Check - def initialize(name, &block) + def initialize(name = nil, &block) super @type = :blocklist end diff --git a/lib/rack/attack/safelist.rb b/lib/rack/attack/safelist.rb index 0bd1453..b3abeaf 100644 --- a/lib/rack/attack/safelist.rb +++ b/lib/rack/attack/safelist.rb @@ -3,7 +3,7 @@ module Rack class Attack class Safelist < Check - def initialize(name, &block) + def initialize(name = nil, &block) super @type = :safelist end