mirror of
https://github.com/samsonjs/rack-attack.git
synced 2026-03-25 09:25:49 +00:00
76c2e31430
The issue
---
When using rack-attack with a rails app, developers expect the request
path to be normalized. In particular, trailing slashes are stripped so
a request path "/login/" becomes "/login" by the time you're in
ActionController.
Since Rack::Attack runs before ActionDispatch, the request path is not
yet normalized. This can cause throttles and blacklists to not work as
expected.
E.g., a throttle:
throttle('logins', ...) {|req| req.path == "/login" }
would not match a request to '/login/', though Rails would route
'/login/' to the same '/login' action.
The solution
---
This patch looks if ActionDispatch's request normalization is loaded,
and if so, uses it to normalize the path before processing throttles,
blacklists, etc.
If it's not loaded, the request path is not modified.
Credit
---
Thanks to Andres Riancho at Include Security for reporting this issue.
63 lines
1.9 KiB
Ruby
63 lines
1.9 KiB
Ruby
require_relative 'spec_helper'
|
|
|
|
describe 'Rack::Attack' do
|
|
allow_ok_requests
|
|
|
|
describe 'normalizing paths' do
|
|
before do
|
|
Rack::Attack.blacklist("banned_path") {|req| req.path == '/foo' }
|
|
end
|
|
|
|
it 'blocks requests with trailing slash' do
|
|
get '/foo/'
|
|
last_response.status.must_equal 403
|
|
end
|
|
end
|
|
|
|
describe 'blacklist' do
|
|
before do
|
|
@bad_ip = '1.2.3.4'
|
|
Rack::Attack.blacklist("ip #{@bad_ip}") {|req| req.ip == @bad_ip }
|
|
end
|
|
|
|
it('has a blacklist') {
|
|
Rack::Attack.blacklists.key?("ip #{@bad_ip}").must_equal true
|
|
}
|
|
|
|
describe "a bad request" do
|
|
before { get '/', {}, 'REMOTE_ADDR' => @bad_ip }
|
|
it "should return a blacklist response" do
|
|
get '/', {}, 'REMOTE_ADDR' => @bad_ip
|
|
last_response.status.must_equal 403
|
|
last_response.body.must_equal "Forbidden\n"
|
|
end
|
|
it "should tag the env" do
|
|
last_request.env['rack.attack.matched'].must_equal "ip #{@bad_ip}"
|
|
last_request.env['rack.attack.match_type'].must_equal :blacklist
|
|
end
|
|
|
|
allow_ok_requests
|
|
end
|
|
|
|
describe "and whitelist" do
|
|
before do
|
|
@good_ua = 'GoodUA'
|
|
Rack::Attack.whitelist("good ua") {|req| req.user_agent == @good_ua }
|
|
end
|
|
|
|
it('has a whitelist'){ Rack::Attack.whitelists.key?("good ua") }
|
|
describe "with a request match both whitelist & blacklist" do
|
|
before { get '/', {}, 'REMOTE_ADDR' => @bad_ip, 'HTTP_USER_AGENT' => @good_ua }
|
|
it "should allow whitelists before blacklists" do
|
|
get '/', {}, 'REMOTE_ADDR' => @bad_ip, 'HTTP_USER_AGENT' => @good_ua
|
|
last_response.status.must_equal 200
|
|
end
|
|
it "should tag the env" do
|
|
last_request.env['rack.attack.matched'].must_equal 'good ua'
|
|
last_request.env['rack.attack.match_type'].must_equal :whitelist
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
end
|