From fc94f2ff0619a5cc2018d3b280ded6d9c33a8899 Mon Sep 17 00:00:00 2001
From: Mihai Parparita <mihai@persistent.info>
Date: Sat, 20 Dec 2014 22:08:06 -0800
Subject: [PATCH] Fix private repositories checkbox not being visible in
 Firefox.

Firefox doesn't support generated content in before/after pseudo classes applied
to <input type="checkbox"> elements. Switch instead to adding the custom
checkbox glyph to the <label> for the checkbox.

Thanks to @snarfed for reporting this.
---
 app/static/main.css                  | 14 +++++++-------
 app/templates/github-auth-error.html |  4 ++--
 app/templates/index-signed-out.html  |  4 ++--
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/app/static/main.css b/app/static/main.css
index 51ce852..139a6bd 100644
--- a/app/static/main.css
+++ b/app/static/main.css
@@ -226,20 +226,20 @@ input[type="submit"].inline.destructive {
 }
 
 #sign-in-form input[type="checkbox"] {
-  visibility: hidden;
+  display: none;
 }
 
-#sign-in-form input[type="checkbox"]:before {
+#sign-in-form input[type="checkbox"] + label:before {
   color: #a02b24;
-  visibility: visible;
   content: "\2610";
   font-size: 18px;
-  position: relative;
-  top: -6px;
-  left: 6px;
 }
 
-#sign-in-form input[type="checkbox"]:checked:before {
+#sign-in-form input[type="checkbox"] + label:active {
+  opacity: 0.4;
+}
+
+#sign-in-form input[type="checkbox"]:checked + label:before {
   content: "\2611";
 }
 
diff --git a/app/templates/github-auth-error.html b/app/templates/github-auth-error.html
index 10de45f..067f0d5 100644
--- a/app/templates/github-auth-error.html
+++ b/app/templates/github-auth-error.html
@@ -13,8 +13,8 @@
   <span class="mega-octicon octicon-mark-github"></span>
   <input type="hidden" name="continue_url" value="{{.ContinueUrl}}">
   <input type="submit" class="action-button" value="Sign In with GitHub">
-  <label>
-    <input type="checkbox" name="include_private" value="1" checked>
+  <input type="checkbox" name="include_private" value="1" checked id="include_private">
+  <label for="include_private">
     Include private repositories
   </label>
 </form>
diff --git a/app/templates/index-signed-out.html b/app/templates/index-signed-out.html
index bbe0deb..195f989 100644
--- a/app/templates/index-signed-out.html
+++ b/app/templates/index-signed-out.html
@@ -22,8 +22,8 @@
   <span class="mega-octicon octicon-mark-github"></span>
   <input type="hidden" name="continue_url" value="{{.ContinueUrl}}">
   <input type="submit" class="action-button" value="Sign In with GitHub">
-  <label>
-    <input type="checkbox" name="include_private" value="1" checked>
+  <input type="checkbox" name="include_private" value="1" checked id="include_private">
+  <label for="include_private">
     Include private repositories
   </label>
 </form>