sjs/samhuri.net
1
0
Fork 0
mirror of https://github.com/samsonjs/samhuri.net.git synced 2026-03-25 09:05:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

update pre-commit hook

Browse source
This commit is contained in:
Sami Samhuri 2016-10-24 16:36:00 -07:00
parent f1cba66d2c
commit 5feb0e62d2
No known key found for this signature in database
GPG key ID: F76F41F04D99808F
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
public/posts/2016/08/ios-git-pre-commit-hook.md
View file

@ -36,12 +36,12 @@ Ok great so this script tells me there are errors. Well, script, what exactly _a
First ignore the fact I'm talking to a shell script. I don't get out much. Anyway... now we need to pull out the regular expressions and globs so we can reuse them to show what the actual errors are if we find any. First ignore the fact I'm talking to a shell script. I don't get out much. Anyway... now we need to pull out the regular expressions and globs so we can reuse them to show what the actual errors are if we find any.
test_pattern='\b(fdescribe|fit|fcontext|xdescribe|xit|xcontext)\b' test_pattern='^\+\s*\b(fdescribe|fit|fcontext|xdescribe|xit|xcontext)\('
test_glob='*Tests.swift *Specs.swift' test_glob='*Tests.swift *Specs.swift'
if diff-index $test_glob | grep '^+' | egrep "$test_pattern" >/dev/null 2>&1 if diff-index $test_glob | egrep "$test_pattern" >/dev/null 2>&1
... ...
_Pro tip: I wrapped test_pattern with `\b` to only match word boundaries to reduce false positives._ _Pro tip: I prefixed test_pattern with `\b` to only match word boundaries to reduce false positives._
And: And:
@ -52,11 +52,11 @@ And:
You may notice that I snuck in `*Specs.swift` as well. Let's not be choosy about file naming. You may notice that I snuck in `*Specs.swift` as well. Let's not be choosy about file naming.
Then we need to show where the errors are by using `git grep`, with an `|| true` at the end because the whole script fails if any single command fails, and `git grep` regularly exits with non-zero status (I didn't look into why that is). Then we need to show where the errors are by using `diff-indef`, with an `|| true` at the end because the whole script fails if any single command fails, and `git diff-index` regularly exits with non-zero status (I didn't look into why that is).
echo "COMMIT REJECTED for fdescribe/fit/fcontext/xdescribe/xit/xcontext." >&2 echo "COMMIT REJECTED for fdescribe/fit/fcontext/xdescribe/xit/xcontext." >&2
echo "Remove focused and disabled tests before committing." >&2 echo "Remove focused and disabled tests before committing." >&2
git grep -E "$test_pattern" $test_glob || true >&2 diff-index $test_glob | egrep -2 "$test_pattern" || true >&2
echo '----' >&2 echo '----' >&2
And for misplaced views: And for misplaced views:
@ -107,13 +107,13 @@ Here's the whole thing put together:
failed=0 failed=0
test_pattern='\b(fdescribe|fit|fcontext|xdescribe|xit|xcontext)\b' test_pattern='^\+\s*\b(fdescribe|fit|fcontext|xdescribe|xit|xcontext)\('
test_glob='*Tests.swift *Specs.swift' test_glob='*Tests.swift *Specs.swift'
if diff-index $test_glob | grep '^+' | egrep "$test_pattern" >/dev/null 2>&1 if diff-index $test_glob | egrep "$test_pattern" >/dev/null 2>&1
then then
echo "COMMIT REJECTED for fdescribe/fit/fcontext/xdescribe/xit/xcontext." >&2 echo "COMMIT REJECTED for fdescribe/fit/fcontext/xdescribe/xit/xcontext." >&2
echo "Remove focused and disabled tests before committing." >&2 echo "Remove focused and disabled tests before committing." >&2
git grep -E "$test_pattern" $test_glob || true >&2 diff-index $test_glob | egrep -2 "$test_pattern" || true >&2
echo '----' >&2 echo '----' >&2
failed=1 failed=1
fi fi