minor improvements, update TODO

This commit is contained in:
Sami Samhuri 2010-12-20 11:41:33 -08:00
parent 7073eb7b96
commit c5a663549a
6 changed files with 10 additions and 10 deletions

4
TODO
View file

@ -3,14 +3,10 @@ TODO
* promote JS links on project pages (the only ones that mention javascript so far!) * promote JS links on project pages (the only ones that mention javascript so far!)
* link to github finder on project pages
* last commit date * last commit date
* svg commit graph * svg commit graph
* favicon
* fix display issues in ie6 * fix display issues in ie6
* semantic markup (section, nav, header, footer, etc) * semantic markup (section, nav, header, footer, etc)

View file

@ -69,6 +69,7 @@
comment.body = comment.body || '' comment.body = comment.body || ''
if (!comment.body) { if (!comment.body) {
alert("is that all you have to say?") alert("is that all you have to say?")
document.getElementById('thoughts').focus()
return false return false
} }

View file

@ -80,7 +80,8 @@
commit: function(repo, sha, cb) { commit: function(repo, sha, cb) {
return new Commit(repo, sha, cb) return new Commit(repo, sha, cb)
}, },
raw: function(repo, sha, cb) { // raw doesn't work with jsonp in the browser ... cors?
raw: isBrowser ? undefined : function(repo, sha, cb) {
return new Raw(repo, sha, cb) return new Raw(repo, sha, cb)
}, },
repo: function(repo, cb) { repo: function(repo, cb) {
@ -143,7 +144,8 @@
has: [ ['commits', 'commits/list/:repo/:branch'] ] has: [ ['commits', 'commits/list/:repo/:branch'] ]
}) })
Commit = createResource('commits/show/:repo/:sha') Commit = createResource('commits/show/:repo/:sha')
Raw = createResource('blob/show/:repo/:sha') // raw doesn't work with jsonp ... cors?
if (!isBrowser) Raw = createResource('blob/show/:repo/:sha')
Repo = createResource('repos/show/:repo', { Repo = createResource('repos/show/:repo', {
has: [ 'branches' has: [ 'branches'
, 'collaborators' , 'collaborators'

View file

@ -1,7 +1,7 @@
/* iPhone and iPad */ /* iPhone and iPad */
@media only screen and (orientation:portrait) and (device-height:1024px), @media only screen and (orientation:portrait) and (device-height:1024px),
only screen and (max-device-width:480px) only screen and (device-width:320px)
{ {
ul.nav { padding: 0.5em ul.nav { padding: 0.5em
; width: 80% ; width: 80%
@ -134,7 +134,8 @@
/* iPhone and iPad landscape */ /* iPhone and iPad landscape */
@media only screen and (orientation: landscape) { @media only screen and (orientation: landscape) and (device-width:768px),
only screen and (orientation: landscape) and (device-width:320px) {
body { font-size: 0.7em } body { font-size: 0.7em }
} }

View file

@ -83,7 +83,7 @@ SJS.filename = "{{filename}}"
<p><input name=name type=text placeholder=name></p> <p><input name=name type=text placeholder=name></p>
<p><input name=email type=text placeholder=email></p> <p><input name=email type=text placeholder=email></p>
<p><input name=url type=text placeholder=url></p> <p><input name=url type=text placeholder=url></p>
<p><textarea name=body placeholder=thoughts></textarea></p> <p><textarea id=thoughts name=body placeholder=thoughts></textarea></p>
<p align=center><input type=submit value='so there'></p> <p align=center><input type=submit value='so there'></p>
</form> </form>
</div> </div>

View file

@ -65,7 +65,7 @@ SJS.filename = "{{filename}}"
<p><input name=name type=text placeholder=name></p> <p><input name=name type=text placeholder=name></p>
<p><input name=email type=text placeholder=email></p> <p><input name=email type=text placeholder=email></p>
<p><input name=url type=text placeholder=url></p> <p><input name=url type=text placeholder=url></p>
<p><textarea name=body placeholder=thoughts></textarea></p> <p><textarea id=thoughts name=body placeholder=thoughts></textarea></p>
<p align=center><input type=submit value='so there'></p> <p align=center><input type=submit value='so there'></p>
</form> </form>
</div> </div>