sjs/simple_oauth
1
0
Fork 0
mirror of https://github.com/samsonjs/simple_oauth.git synced 2026-03-25 08:45:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix the reserved characters regex to be non-variant by KCODE

Browse source
This commit is contained in:
Erik Michaels-Ober 2010-11-15 08:31:03 -08:00
parent bfbe667da4
commit a39ceda4ba
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/simple_oauth.rb
View file

@ -24,7 +24,7 @@ module SimpleOAuth
end
def self.encode(value)
URI.encode(value.to_s, /[^\w\-\.\~]/)
URI.encode(value.to_s, /[^a-z0-9\-\.\_\~]/i)
end
def self.decode(value)

13
test/simple_oauth_test.rb
View file

@ -30,6 +30,19 @@ class SimpleOAuthTest < Test::Unit::TestCase
['-', '.', '~'].each do |character|
assert_equal character, SimpleOAuth::Header.encode(character)
end
major, minor, patch = RUBY_VERSION.split('.')
new_ruby = major.to_i >= 2 || major.to_i == 1 && minor.to_i >= 9
old_kcode = $KCODE if !new_ruby
begin
%w(n N e E s S u U).each do |kcode|
$KCODE = kcode if !new_ruby
assert_equal '%E3%81%82', SimpleOAuth::Header.encode('あ'), "Failed to correctly escape Japanese under $KCODE = #{kcode}"
assert_equal '%C3%A9', SimpleOAuth::Header.encode('é'), "Failed to correctly escape e+acute under $KCODE = #{kcode}"
end
ensure
$KCODE = old_kcode if !new_ruby
end
end
def test_decode