sjs/spirit-tracker
1
0
Fork 0
mirror of https://github.com/samsonjs/spirit-tracker.git synced 2026-03-25 09:25:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

UX Improvements

Browse source
This commit is contained in:
Brennan Wilkes (Text Groove) 2026-02-09 23:53:16 -08:00
parent 09cec6a161
commit 01c16007df
1 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
viz/app/item_page.js
View file

@ -117,6 +117,9 @@ const StaticMarkerLinesPlugin = {
const markers = Array.isArray(opts?.markers) ? opts.markers : []; const markers = Array.isArray(opts?.markers) ? opts.markers : [];
if (!markers.length) return; if (!markers.length) return;
const markerYs = markers.map(m => Number(m.y)).filter(Number.isFinite);
const HIDE_TICK_PX = 9; // tweak 6–12 depending on font size
// Find y-scale (v2/v3 tolerant) // Find y-scale (v2/v3 tolerant)
const scalesObj = chart?.scales || {}; const scalesObj = chart?.scales || {};
const scales = Object.values(scalesObj); const scales = Object.values(scalesObj);
@ -993,11 +996,25 @@ export async function renderItem($app, skuInput) {
x: { ticks: { maxRotation: 0, autoSkip: true, maxTicksLimit: 12 }, grid: { display: false } }, x: { ticks: { maxRotation: 0, autoSkip: true, maxTicksLimit: 12 }, grid: { display: false } },
y: { y: {
...ySug, ...ySug,
ticks: { ticks: {
stepSize: step, stepSize: step,
maxTicksLimit: MAX_TICKS, maxTicksLimit: MAX_TICKS,
callback: (v) => `$${Number(v).toFixed(0)}`,
padding: 10, padding: 10,
callback: function (v) {
const val = Number(v);
if (!Number.isFinite(val)) return "";
// `this` is the y-scale in Chart.js (v2/v3/v4)
const py = this.getPixelForValue(val);
for (const my of markerYs) {
const pmy = this.getPixelForValue(my);
if (Math.abs(py - pmy) <= HIDE_TICK_PX) return ""; // hide $ tick label
}
return `$${val.toFixed(0)}`;
},
}, },
}, },
}, },