sjs/spirit-tracker
1
0
Fork 0
mirror of https://github.com/samsonjs/spirit-tracker.git synced 2026-03-25 09:25:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

UX Improvements

Browse source
This commit is contained in:
Brennan Wilkes (Text Groove) 2026-02-05 16:36:24 -08:00
parent 5ef30bb652
commit 1a5b638c58
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
viz/app/store_page.js
View file

@ -580,13 +580,13 @@ export async function renderStore($app, storeLabelRaw) {
function exclusiveAnnotHtml(it) { function exclusiveAnnotHtml(it) {
const mode = String($exSort.value || "priceDesc"); const mode = String($exSort.value || "priceDesc");
// If sorting by sale, annotate with sale change ($ / %). If unchanged, show nothing. // Sale sorts: show price change for THIS store (7d recent), unchanged => nothing.
if (mode === "salePct") { if (mode === "salePct") {
const p = Number.isFinite(it._salePct) ? it._salePct : 0; const p = Number.isFinite(it._salePct) ? it._salePct : 0;
if (!p) return ""; if (!p) return "";
const abs = Math.abs(p); const abs = Math.abs(p);
if (p < 0) return `<span class="badge badgeGood">[${esc(abs)}% Off]</span>`; if (p < 0) return `<span class="badge badgeGood">${esc(abs)}% off</span>`;
return `<span class="badge badgeBad">[+${esc(abs)}%]</span>`; return `<span class="badge badgeBad">+${esc(abs)}%</span>`;
} }
if (mode === "saleAbs") { if (mode === "saleAbs") {
@ -594,11 +594,12 @@ export async function renderStore($app, storeLabelRaw) {
if (!d) return ""; if (!d) return "";
const abs = Math.round(Math.abs(d)); const abs = Math.round(Math.abs(d));
if (!abs) return ""; if (!abs) return "";
if (d < 0) return `<span class="badge badgeGood">[-$${esc(abs)}]</span>`; if (d < 0) return `<span class="badge badgeGood">$${esc(abs)} off</span>`;
return `<span class="badge badgeBad">[+$${esc(abs)}]</span>`; return `<span class="badge badgeBad">+$${esc(abs)}</span>`;
} }
// Otherwise: show % off vs best other store (only when actually cheaper). // Any non-sale sort: still show % off on exclusives/last-stock when applicable.
// (% off vs best other store price)
const sp = it && Number.isFinite(it._storePrice) ? it._storePrice : null; const sp = it && Number.isFinite(it._storePrice) ? it._storePrice : null;
const other = it && Number.isFinite(it._bestOther) ? it._bestOther : null; const other = it && Number.isFinite(it._bestOther) ? it._bestOther : null;
if (sp === null || other === null || !(other > 0)) return ""; if (sp === null || other === null || !(other > 0)) return "";
@ -606,7 +607,7 @@ export async function renderStore($app, storeLabelRaw) {
const pct = Math.round(((other - sp) / other) * 100); const pct = Math.round(((other - sp) / other) * 100);
if (!Number.isFinite(pct) || pct <= 0) return ""; if (!Number.isFinite(pct) || pct <= 0) return "";
return `<span class="badge badgeGood">[${esc(pct)}% Off]</span>`; return `<span class="badge badgeGood">${esc(pct)}% off</span>`;
} }