mirror of
https://github.com/samsonjs/vibetunnel.git
synced 2026-04-27 15:17:38 +00:00
Fix mobile horizontal fit with Fira Code font consistency
- Remove debug logging after confirming font fix works - Fira Code provides consistent character width across platforms - Horizontal fit now works reliably on real devices and emulators - Minimum font size of 4px enables proper mobile fitting 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
parent
4dd6d941d8
commit
12eaa39d73
2 changed files with 12 additions and 30 deletions
|
|
@ -380,7 +380,7 @@
|
||||||
// ASCII art
|
// ASCII art
|
||||||
content += '\x1b[1;31m🎭 ASCII Art:\x1b[0m\r\n';
|
content += '\x1b[1;31m🎭 ASCII Art:\x1b[0m\r\n';
|
||||||
content += '\x1b[33m ╭────────────────────────────────────╮\r\n';
|
content += '\x1b[33m ╭────────────────────────────────────╮\r\n';
|
||||||
content += '\x1b[33m │ \x1b[36m*\x1b[32m+\x1b[35m#\x1b[31mo \x1b[1;37mDOM Terminal Ready! \x1b[31mo\x1b[35m#\x1b[32m+\x1b[36m*\x1b[33m │\r\n';
|
content += '\x1b[33m │ \x1b[36m*\x1b[32m+\x1b[35m#\x1b[31mo \x1b[1;37mDOM Terminal Ready! \x1b[31mo\x1b[35m#\x1b[32m+\x1b[36m*\x1b[33m │\r\n';
|
||||||
content += '\x1b[33m ╰────────────────────────────────────╯\x1b[0m\r\n\r\n';
|
content += '\x1b[33m ╰────────────────────────────────────╯\x1b[0m\r\n\r\n';
|
||||||
|
|
||||||
// Interactive instructions
|
// Interactive instructions
|
||||||
|
|
|
||||||
|
|
@ -145,10 +145,7 @@ export class Terminal extends LitElement {
|
||||||
}
|
}
|
||||||
|
|
||||||
private measureCharacterWidth(): number {
|
private measureCharacterWidth(): number {
|
||||||
if (!this.container) {
|
if (!this.container) return 8;
|
||||||
console.log('measureCharacterWidth: no container, returning default 8px');
|
|
||||||
return 8;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Create temporary element with same styles as terminal content, attached to container
|
// Create temporary element with same styles as terminal content, attached to container
|
||||||
const measureEl = document.createElement('div');
|
const measureEl = document.createElement('div');
|
||||||
|
|
@ -167,16 +164,12 @@ export class Terminal extends LitElement {
|
||||||
const testContent = testString.repeat(repeatCount).substring(0, this.cols);
|
const testContent = testString.repeat(repeatCount).substring(0, this.cols);
|
||||||
measureEl.textContent = testContent;
|
measureEl.textContent = testContent;
|
||||||
|
|
||||||
console.log(`measureCharacterWidth: measuring ${this.cols} chars with fontSize=${this.fontSize}px, testContent length: ${testContent.length}`);
|
|
||||||
|
|
||||||
// Attach to container so it inherits all the proper CSS context
|
// Attach to container so it inherits all the proper CSS context
|
||||||
this.container.appendChild(measureEl);
|
this.container.appendChild(measureEl);
|
||||||
const measureRect = measureEl.getBoundingClientRect();
|
const measureRect = measureEl.getBoundingClientRect();
|
||||||
const actualCharWidth = measureRect.width / this.cols;
|
const actualCharWidth = measureRect.width / this.cols;
|
||||||
this.container.removeChild(measureEl);
|
this.container.removeChild(measureEl);
|
||||||
|
|
||||||
console.log(`measureCharacterWidth: measureRect.width=${measureRect.width}px, cols=${this.cols}, calculated charWidth=${actualCharWidth}px`);
|
|
||||||
|
|
||||||
return actualCharWidth;
|
return actualCharWidth;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
@ -189,8 +182,6 @@ export class Terminal extends LitElement {
|
||||||
const containerHeight = this.container.clientHeight;
|
const containerHeight = this.container.clientHeight;
|
||||||
const targetCharWidth = containerWidth / this.cols;
|
const targetCharWidth = containerWidth / this.cols;
|
||||||
|
|
||||||
console.log(`Horizontal fit: container ${containerWidth}x${containerHeight}px, target charWidth=${targetCharWidth}px for ${this.cols} cols`);
|
|
||||||
|
|
||||||
// Calculate fontSize needed for target character width
|
// Calculate fontSize needed for target character width
|
||||||
// Use current font size as starting point and measure actual character width
|
// Use current font size as starting point and measure actual character width
|
||||||
const currentCharWidth = this.measureCharacterWidth();
|
const currentCharWidth = this.measureCharacterWidth();
|
||||||
|
|
@ -198,16 +189,12 @@ export class Terminal extends LitElement {
|
||||||
const calculatedFontSize = this.fontSize * scaleFactor;
|
const calculatedFontSize = this.fontSize * scaleFactor;
|
||||||
const newFontSize = Math.max(4, Math.min(32, calculatedFontSize));
|
const newFontSize = Math.max(4, Math.min(32, calculatedFontSize));
|
||||||
|
|
||||||
console.log(`Horizontal fit: currentCharWidth=${currentCharWidth}px, scaleFactor=${scaleFactor}, calculatedFontSize=${calculatedFontSize}px, clampedFontSize=${newFontSize}px`);
|
|
||||||
|
|
||||||
this.fontSize = newFontSize;
|
this.fontSize = newFontSize;
|
||||||
|
|
||||||
// Also fit rows to use full container height with the new font size
|
// Also fit rows to use full container height with the new font size
|
||||||
const lineHeight = this.fontSize * 1.2;
|
const lineHeight = this.fontSize * 1.2;
|
||||||
const fittedRows = Math.max(1, Math.floor(containerHeight / lineHeight));
|
const fittedRows = Math.max(1, Math.floor(containerHeight / lineHeight));
|
||||||
|
|
||||||
console.log(`Horizontal fit: lineHeight=${lineHeight}px, fittedRows=${fittedRows}`);
|
|
||||||
|
|
||||||
// Update both actualRows and the terminal's actual row count
|
// Update both actualRows and the terminal's actual row count
|
||||||
this.actualRows = fittedRows;
|
this.actualRows = fittedRows;
|
||||||
this.rows = fittedRows;
|
this.rows = fittedRows;
|
||||||
|
|
@ -216,16 +203,11 @@ export class Terminal extends LitElement {
|
||||||
if (this.terminal) {
|
if (this.terminal) {
|
||||||
this.terminal.resize(this.cols, this.rows);
|
this.terminal.resize(this.cols, this.rows);
|
||||||
}
|
}
|
||||||
|
|
||||||
console.log(
|
|
||||||
`Horizontal fit: FINAL fontSize ${this.fontSize}px, ${this.cols}x${this.rows} in ${containerWidth}x${containerHeight}px`
|
|
||||||
);
|
|
||||||
} else {
|
} else {
|
||||||
// Normal mode: just calculate how many rows fit in the viewport
|
// Normal mode: just calculate how many rows fit in the viewport
|
||||||
const containerHeight = this.container.clientHeight;
|
const containerHeight = this.container.clientHeight;
|
||||||
const lineHeight = this.fontSize * 1.2;
|
const lineHeight = this.fontSize * 1.2;
|
||||||
this.actualRows = Math.max(1, Math.floor(containerHeight / lineHeight));
|
this.actualRows = Math.max(1, Math.floor(containerHeight / lineHeight));
|
||||||
console.log(`Viewport fits ${this.actualRows} rows`);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
this.requestUpdate();
|
this.requestUpdate();
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue