sjs/vibetunnel
1
0
Fork 0
mirror of https://github.com/samsonjs/vibetunnel.git synced 2026-04-27 15:17:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix lint errors in file browser test

Browse source 
- Remove non-null assertion in favor of proper null check
- Add z-index comments for clarity in modal overlays
- Remove unused Z_INDEX imports after switching to comments

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Jeff Hurray 2025-07-08 13:07:26 -07:00 committed by Peter Steinberger
parent 913cce61d2
commit 14f5315ab0
3 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
web/src/client/components/session-view/ctrl-alpha-overlay.ts
View file

@ -33,8 +33,8 @@ export class CtrlAlphaOverlay extends LitElement {
return html` return html`
<modal-wrapper <modal-wrapper
.visible=${this.visible} .visible=${this.visible}
modalClass="z-50" modalClass="z-50" /* z-50 ensures overlay appears above other UI elements */
contentClass="fixed inset-0 flex flex-col z-50" contentClass="fixed inset-0 flex flex-col z-50" /* z-50 matches modal z-index */
ariaLabel="Ctrl key sequence builder" ariaLabel="Ctrl key sequence builder"
@close=${() => this.onCancel?.()} @close=${() => this.onCancel?.()}
.closeOnBackdrop=${true} .closeOnBackdrop=${true}

4
web/src/client/components/session-view/mobile-input-overlay.ts
View file

@ -211,8 +211,8 @@ export class MobileInputOverlay extends LitElement {
return html` return html`
<modal-wrapper <modal-wrapper
.visible=${this.visible} .visible=${this.visible}
modalClass="z-40" modalClass="z-40" /* z-40 ensures overlay appears above base UI elements */
contentClass="fixed inset-0 flex flex-col z-40" contentClass="fixed inset-0 flex flex-col z-40" /* z-40 matches modal backdrop z-index */
ariaLabel="Mobile input overlay" ariaLabel="Mobile input overlay"
@close=${() => this.onCancel?.()} @close=${() => this.onCancel?.()}
.closeOnBackdrop=${true} .closeOnBackdrop=${true}

8
web/src/test/playwright/specs/file-browser-session-create.spec.ts
View file

@ -32,9 +32,11 @@ test.describe('File Browser in Session Create Form', () => {
await expect(fileBrowser).toBeVisible({ timeout: 5000 }); await expect(fileBrowser).toBeVisible({ timeout: 5000 });
// Verify file browser is above session create modal by checking z-index // Verify file browser is above session create modal by checking z-index
const fileBrowserZIndex = await fileBrowser.evaluate( const fileBrowserZIndex = await fileBrowser.evaluate((el) => {
(el) => window.getComputedStyle(el.parentElement!).zIndex const parent = el.parentElement;
); if (!parent) return '0';
return window.getComputedStyle(parent).zIndex;
});
expect(Number.parseInt(fileBrowserZIndex)).toBeGreaterThan(1000); // Modal backdrop is z-index: 1000 expect(Number.parseInt(fileBrowserZIndex)).toBeGreaterThan(1000); // Modal backdrop is z-index: 1000
// Verify we can interact with file browser (not blocked by modal) // Verify we can interact with file browser (not blocked by modal)