sjs/vibetunnel
1
0
Fork 0
mirror of https://github.com/samsonjs/vibetunnel.git synced 2026-04-27 15:17:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve error logging

Browse source
This commit is contained in:
Peter Steinberger 2025-06-20 19:03:40 +02:00
parent bb9702e52d
commit 35c2908a57
1 changed files with 19 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
linux/pkg/session/pty.go
View file

@ -53,10 +53,17 @@ func NewPTY(session *Session) (*PTY, error) {
// If just launching the shell itself, don't use -c
cmd = exec.Command(shell)
} else {
// Execute command through shell for proper environment handling
// Execute command through interactive login shell for proper environment handling
// This ensures aliases and functions from .zshrc/.bashrc are loaded
shellCmd := strings.Join(cmdline, " ")
cmd = exec.Command(shell, "-c", shellCmd)
debugLog("[DEBUG] NewPTY: Executing through shell: %s -c %q", shell, shellCmd)
// Use interactive login shell to load user's configuration
cmd = exec.Command(shell, "-i", "-l", "-c", shellCmd)
debugLog("[DEBUG] NewPTY: Executing through interactive login shell: %s -i -l -c %q", shell, shellCmd)
// Add some debugging to understand what's happening
debugLog("[DEBUG] NewPTY: Shell: %s", shell)
debugLog("[DEBUG] NewPTY: Command: %v", cmdline)
debugLog("[DEBUG] NewPTY: Shell command: %s", shellCmd)
}
// Set working directory, ensuring it's valid
@ -96,8 +103,15 @@ func NewPTY(session *Session) (*PTY, error) {
ptmx, err := pty.Start(cmd)
if err != nil {
log.Printf("[ERROR] NewPTY: Failed to start PTY: %v", err)
return nil, ErrPTYCreationError(session.ID, err)
// Provide more helpful error message for common failures
errorMsg := fmt.Sprintf("Failed to start PTY for command '%s'", strings.Join(cmdline, " "))
if strings.Contains(err.Error(), "no such file or directory") || strings.Contains(err.Error(), "not found") {
errorMsg = fmt.Sprintf("Command '%s' not found. Make sure it's installed and in your PATH, or is a valid shell alias/function.", cmdline[0])
} else if strings.Contains(err.Error(), "permission denied") {
errorMsg = fmt.Sprintf("Permission denied executing '%s'", strings.Join(cmdline, " "))
}
log.Printf("[ERROR] NewPTY: %s: %v", errorMsg, err)
return nil, NewSessionErrorWithCause(errorMsg, ErrPTYCreationFailed, session.ID, err)
}
debugLog("[DEBUG] NewPTY: PTY started successfully, PID: %d", cmd.Process.Pid)