sjs/vibetunnel
1
0
Fork 0
mirror of https://github.com/samsonjs/vibetunnel.git synced 2026-03-25 09:25:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Configure iOS team ID via xcconfig to prevent project file conflicts (#186)

Browse source 
* fix: remove hardcoded team ID from project, use xcconfig inheritance

- Remove hardcoded DEVELOPMENT_TEAM from project.pbxproj to prevent conflicts
- Fix xcconfig hierarchy so Local.xcconfig properly overrides defaults
- Set Y5PE65HELJ as fallback for CI when Local.xcconfig doesn't exist
- Local developers can now use their own team ID without project file changes

* fix: revert to using $(inherited) for team ID instead of hardcoding

The original setup was correct - using $(inherited) allows the team ID to be
set from Local.xcconfig while falling back to project settings when needed.
Hardcoding the team ID was unnecessary and went against the established pattern.

* fix: restore Local.xcconfig to membershipExceptions

Local.xcconfig must remain in membershipExceptions to prevent Xcode from
incorrectly treating it as a compilable source file. Configuration files
should be excluded from compilation and referenced via baseConfigurationReference.

Without this exception, Xcode attempts to compile Local.xcconfig as source code,
causing build errors and warnings, especially problematic for git-ignored files.

---------

Co-authored-by: David Collado <davidcollado@MacBook-Pro-de-David.local>
This commit is contained in:
David 2025-07-02 23:33:19 +02:00 committed by GitHub
parent a4619fb766
commit 38cd396b8a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ios/VibeTunnel-iOS.xcodeproj/project.pbxproj
View file

@ -358,7 +358,6 @@
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 1;
DEBUG_INFORMATION_FORMAT = dwarf;
DEVELOPMENT_TEAM = Y5PE65HELJ;
ENABLE_PREVIEWS = YES;
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_TESTABILITY = YES;
@ -460,7 +459,6 @@
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 1;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = Y5PE65HELJ;
ENABLE_NS_ASSERTIONS = NO;
ENABLE_PREVIEWS = YES;
ENABLE_STRICT_OBJC_MSGSEND = YES;