sjs/vibetunnel
1
0
Fork 0
mirror of https://github.com/samsonjs/vibetunnel.git synced 2026-04-27 15:17:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix missing public directory in Mac app bundle (#392)

Browse source
This commit is contained in:
Peter Steinberger 2025-07-17 14:12:34 +02:00 committed by GitHub
parent 3fa79e0f1b
commit 5bdc7f7b1b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 24 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
mac/VibeTunnel/Core/Services/BunServer.swift
View file

@ -268,6 +268,10 @@ final class BunServer {
// Add Node.js memory settings as command line arguments instead of NODE_OPTIONS // Add Node.js memory settings as command line arguments instead of NODE_OPTIONS
// NODE_OPTIONS can interfere with SEA binaries // NODE_OPTIONS can interfere with SEA binaries
// Set BUILD_PUBLIC_PATH to help the server find static files in the app bundle
environment["BUILD_PUBLIC_PATH"] = staticPath
logger.info("Setting BUILD_PUBLIC_PATH=\(staticPath)")
process.environment = environment process.environment = environment

25
web/scripts/test-vt-syntax.sh
View file

@ -64,17 +64,22 @@ if [ -f "$PACKAGE_JSON" ]; then
fi fi
# Test 7: Basic functionality test (help command) # Test 7: Basic functionality test (help command)
# Use gtimeout if available, otherwise skip timeout # Skip this test if we're already inside a VibeTunnel session
if command -v gtimeout >/dev/null 2>&1; then if [ -n "$VIBETUNNEL_SESSION_ID" ]; then
if ! gtimeout 5 "$VT_SCRIPT" --help >/dev/null 2>&1; then echo "✅ vt script detected we're inside a VibeTunnel session (expected behavior)"
echo "❌ ERROR: vt --help command failed or timed out"
exit 1
fi
else else
# On macOS without gtimeout, just test that it doesn't immediately fail # Use gtimeout if available, otherwise skip timeout
if ! "$VT_SCRIPT" --help >/dev/null 2>&1; then if command -v gtimeout >/dev/null 2>&1; then
echo "❌ ERROR: vt --help command failed" if ! gtimeout 5 "$VT_SCRIPT" --help >/dev/null 2>&1; then
exit 1 echo "❌ ERROR: vt --help command failed or timed out"
exit 1
fi
else
# On macOS without gtimeout, just test that it doesn't immediately fail
if ! "$VT_SCRIPT" --help >/dev/null 2>&1; then
echo "❌ ERROR: vt --help command failed"
exit 1
fi
fi fi
fi fi
echo "✅ vt --help command works" echo "✅ vt --help command works"

5
web/src/server/server.ts
View file

@ -561,6 +561,11 @@ export async function createApp(): Promise<AppInstance> {
// Serve static files with .html extension handling and caching headers // Serve static files with .html extension handling and caching headers
// In production/bundled mode, use the package directory; in development, use cwd // In production/bundled mode, use the package directory; in development, use cwd
const getPublicPath = () => { const getPublicPath = () => {
// First check if BUILD_PUBLIC_PATH is set (used by Mac app bundle)
if (process.env.BUILD_PUBLIC_PATH) {
logger.info(`Using BUILD_PUBLIC_PATH: ${process.env.BUILD_PUBLIC_PATH}`);
return process.env.BUILD_PUBLIC_PATH;
}
// More precise npm package detection: // More precise npm package detection:
// 1. Check if we're explicitly in an npm package structure // 1. Check if we're explicitly in an npm package structure
// 2. The file should be in node_modules/vibetunnel/lib/ // 2. The file should be in node_modules/vibetunnel/lib/