From ac55f9685c14ad1f41ea5a002cbeb45e66de6d18 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sat, 12 Jul 2025 19:07:55 +0200 Subject: [PATCH] ci: simplify Mac workflow by removing Node.js dependency MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the dependency on Node.js CI job for Mac and iOS builds, and always build web artifacts locally in the Mac workflow. This simplifies the CI pipeline and removes the artifact download step that could fail. Changes: - Remove `node` dependency from `mac` and `ios` jobs in ci.yml - Replace artifact download with direct web build in mac.yml - Simplify the build process by removing conditional logic This extracts the CI workflow improvements from PR #318. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- .github/workflows/ci.yml | 4 ++-- .github/workflows/mac.yml | 25 +++++++------------------ 2 files changed, 9 insertions(+), 20 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4d124fa4..d0602efd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -52,7 +52,7 @@ jobs: mac: name: Mac CI - needs: [changes, node] + needs: [changes] if: | always() && !contains(needs.*.result, 'failure') && @@ -62,7 +62,7 @@ jobs: ios: name: iOS CI - needs: [changes, node] + needs: [changes] if: | always() && !contains(needs.*.result, 'failure') && diff --git a/.github/workflows/mac.yml b/.github/workflows/mac.yml index 147f7d28..8e7c53ec 100644 --- a/.github/workflows/mac.yml +++ b/.github/workflows/mac.yml @@ -141,25 +141,14 @@ jobs: fi done - - name: Download web build artifacts - uses: actions/download-artifact@v4 - continue-on-error: true - with: - name: web-build-${{ github.sha }} - path: web/ - - - name: Build web artifacts if missing + - name: Build web artifacts run: | - if [ ! -d "web/dist" ] || [ ! -d "web/public/bundle" ]; then - echo "Web build artifacts not found, building locally..." - cd web - # Skip custom Node.js build in CI to avoid timeout - export CI=true - pnpm run build - echo "Web artifacts built successfully" - else - echo "Web build artifacts found, skipping local build" - fi + echo "Building web artifacts locally..." + cd web + # Skip custom Node.js build in CI to avoid timeout + export CI=true + pnpm run build + echo "Web artifacts built successfully" - name: Resolve Dependencies (once) run: |