From cf7ada95e3d6687ce1494ba7491c77e011cdea9f Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Tue, 1 Jul 2025 13:30:05 +0100 Subject: [PATCH] fix: Remove incorrect stdin cleanup code - Remove stdin handler cleanup that was contradicting the comment - Remove unused stdinHandler and stdinDataListener from PtySession interface - Stdin is handled via IPC socket, not process.stdin listeners --- web/src/server/pty/pty-manager.ts | 10 +--------- web/src/server/pty/types.ts | 2 -- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/web/src/server/pty/pty-manager.ts b/web/src/server/pty/pty-manager.ts index d4288643..5b7df0cc 100644 --- a/web/src/server/pty/pty-manager.ts +++ b/web/src/server/pty/pty-manager.ts @@ -1853,15 +1853,7 @@ export class PtyManager extends EventEmitter { session.sessionJsonWatcher.close(); } - // Clean up stdin handlers if they exist - if (session.stdinHandler) { - process.stdin.removeListener('data', session.stdinHandler); - session.stdinHandler = undefined; - } - if (session.stdinDataListener) { - process.stdin.removeListener('data', session.stdinDataListener); - session.stdinDataListener = undefined; - } + // Note: stdin handling is done via IPC socket, no global listeners to clean up // Remove all event listeners for this session const listeners = this.sessionEventListeners.get(session.id); diff --git a/web/src/server/pty/types.ts b/web/src/server/pty/types.ts index 235d850d..825bfc4e 100644 --- a/web/src/server/pty/types.ts +++ b/web/src/server/pty/types.ts @@ -71,8 +71,6 @@ export interface PtySession { inputSocketServer?: net.Server; sessionJsonWatcher?: fs.FSWatcher; sessionJsonDebounceTimer?: NodeJS.Timeout | null; - stdinHandler?: (data: string) => void; - stdinDataListener?: (data: Buffer) => void; stdoutQueue?: WriteQueue; // Terminal title mode titleMode?: TitleMode;