From dd4e06f2492b0701f144b991264f20c75692af3b Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Tue, 1 Jul 2025 13:15:35 +0100
Subject: [PATCH] fix: Improve timer management and error handling in PTY
 manager

- Fix timer management in setupSessionJsonWatcher to properly assign timer before setTimeout
- Improve IPC socket error handling to throw error instead of silently returning
- Socket path length validation now fails fast with clear error message
---
 web/src/server/pty/pty-manager.ts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/web/src/server/pty/pty-manager.ts b/web/src/server/pty/pty-manager.ts
index 0efe3d4f..d8c4eeff 100644
--- a/web/src/server/pty/pty-manager.ts
+++ b/web/src/server/pty/pty-manager.ts
@@ -695,11 +695,12 @@ export class PtyManager extends EventEmitter {
 
     // Verify the socket path isn't too long
     if (socketPath.length > 103) {
+      const error = new Error(`Socket path too long: ${socketPath.length} characters`);
       logger.error(`Socket path too long (${socketPath.length} chars): ${socketPath}`);
       logger.error(
         `macOS limit is 103 characters. Consider using shorter session IDs or control paths.`
       );
-      return;
+      throw error; // Fail fast instead of returning silently
     }
 
     try {
@@ -800,15 +801,16 @@ export class PtyManager extends EventEmitter {
             clearTimeout(debounceTimer);
           }
 
-          debounceTimer = setTimeout(() => {
+          const timer = setTimeout(() => {
             this.handleSessionJsonChange(session);
             // Clear both timer references after execution
             session.sessionJsonDebounceTimer = null;
             debounceTimer = null;
           }, 100);
 
-          // Update the session's timer reference
-          session.sessionJsonDebounceTimer = debounceTimer;
+          // Update both timer references
+          session.sessionJsonDebounceTimer = timer;
+          debounceTimer = timer;
         }
       });