vibetunnel/linux/pkg/api/websocket.go
Helmut Januschka a66620be52
fix: Go server CPU optimization & resize control flag (#32)
* fix: optimize Go server CPU usage from 500%+ to efficient levels

Major performance improvements to resolve excessive CPU consumption:

**Critical Fixes:**
- Remove WebSocket busy loop that caused continuous CPU spinning
- Fix microsecond-level polling (100μs → 10ms) reducing 100x operations
- Replace ps subprocess calls with efficient kill(pid,0) syscalls
- Increase timer intervals (1s → 30s) for session status checks

**Optimizations:**
- Control FIFO polling: 100ms → 1s intervals
- Select timeout: 100ms → 1s to reduce unnecessary wakeups
- Smart status caching: skip checks for already-exited sessions
- Remove unused imports (os/exec, strconv)

**Impact:**
- Eliminates tight loops causing 10,000+ operations per second
- Reduces subprocess overhead from frequent ps command executions
- Changes from polling-based to efficient event-driven architecture
- Expected CPU usage reduction from 500%+ to levels comparable with Node.js version

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: prevent WebSocket channel close panic with sync.Once

- Add sync.Once to prevent double-closing of done channel
- Update handleTextMessage signature to accept close function
- Use closeOnceFunc for safe channel closure across goroutines

Fixes panic: 'close of closed channel' in WebSocket handler

* feat: add --do-not-allow-column-set flag to disable resizing for spawned sessions

**New Flag:**
- `--do-not-allow-column-set` (default: true) - Disables terminal resizing for spawned shells
- Only affects sessions created with `spawn_terminal=true`
- Detached sessions (command-line, API without spawn) always allow resizing

**Implementation:**
- Add `IsSpawned` field to session.Config and session.Info structs
- Track whether session was spawned in terminal vs detached
- Server checks flag + spawn status before allowing resize operations
- Returns descriptive error for blocked resize attempts

**Behavior:**
- Spawned sessions: Resize blocked when flag enabled (default)
- Detached sessions: Always allow resizing regardless of flag
- Existing sessions preserve their resize capabilities

**API Response for blocked resize:**
```json
{
  "success": false,
  "message": "Resizing is disabled for spawned sessions",
  "error": "resize_disabled_for_spawned_sessions"
}
```

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat: extend --do-not-allow-column-set flag to block ALL session resizing

**Breaking Change:** Flag now affects both spawned AND detached sessions

**Changes:**
- Remove `sess.IsSpawned()` check in resize handler
- Block resizing for ALL sessions when flag is enabled (default: true)
- Update flag description: "Disable terminal resizing for all sessions (spawned and detached)"
- Update error message: "Terminal resizing is disabled by server configuration"
- Update error code: "resize_disabled_by_server"

**New Behavior:**
- `--do-not-allow-column-set=true` (default): NO resizing for any session type
- `--do-not-allow-column-set=false`: Allow resizing for all session types
- Applies uniformly to both spawned terminal windows and detached CLI sessions

**API Response for blocked resize:**
```json
{
  "success": false,
  "message": "Terminal resizing is disabled by server configuration",
  "error": "resize_disabled_by_server"
}
```

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2025-06-20 11:37:54 +02:00

423 lines
10 KiB
Go

package api
import (
"encoding/binary"
"encoding/json"
"fmt"
"log"
"net/http"
"os"
"strings"
"sync"
"time"
"github.com/fsnotify/fsnotify"
"github.com/gorilla/websocket"
"github.com/vibetunnel/linux/pkg/protocol"
"github.com/vibetunnel/linux/pkg/session"
)
const (
// Magic byte for binary messages
BufferMagicByte = 0xbf
// WebSocket timeouts
writeWait = 10 * time.Second
pongWait = 60 * time.Second
pingPeriod = (pongWait * 9) / 10
maxMessageSize = 512 * 1024 // 512KB
)
var upgrader = websocket.Upgrader{
CheckOrigin: func(r *http.Request) bool {
// Allow all origins for now
return true
},
ReadBufferSize: 1024,
WriteBufferSize: 1024,
}
type BufferWebSocketHandler struct {
manager *session.Manager
clients sync.Map // sessionID -> *websocket.Conn
}
func NewBufferWebSocketHandler(manager *session.Manager) *BufferWebSocketHandler {
return &BufferWebSocketHandler{
manager: manager,
}
}
// safeSend safely sends data to a channel, returning false if the channel is closed
func safeSend(send chan []byte, data []byte, done chan struct{}) bool {
defer func() {
if r := recover(); r != nil {
// Channel was closed, ignore the panic
}
}()
select {
case send <- data:
return true
case <-done:
return false
}
}
func (h *BufferWebSocketHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
conn, err := upgrader.Upgrade(w, r, nil)
if err != nil {
log.Printf("[WebSocket] Failed to upgrade connection: %v", err)
return
}
defer conn.Close()
// Set up connection parameters
conn.SetReadLimit(maxMessageSize)
conn.SetReadDeadline(time.Now().Add(pongWait))
conn.SetPongHandler(func(string) error {
conn.SetReadDeadline(time.Now().Add(pongWait))
return nil
})
// Start ping ticker
ticker := time.NewTicker(pingPeriod)
defer ticker.Stop()
// Channel for writing messages
send := make(chan []byte, 256)
done := make(chan struct{})
var closeOnce sync.Once
// Helper function to safely close done channel
closeOnceFunc := func() {
closeOnce.Do(func() {
close(done)
})
}
// Start writer goroutine
go h.writer(conn, send, ticker, done)
// Handle incoming messages - remove busy loop
for {
messageType, message, err := conn.ReadMessage()
if err != nil {
if websocket.IsUnexpectedCloseError(err, websocket.CloseGoingAway, websocket.CloseAbnormalClosure) {
log.Printf("[WebSocket] Error: %v", err)
}
closeOnceFunc()
return
}
if messageType == websocket.TextMessage {
h.handleTextMessage(conn, message, send, done, closeOnceFunc)
}
}
}
func (h *BufferWebSocketHandler) handleTextMessage(conn *websocket.Conn, message []byte, send chan []byte, done chan struct{}, closeFunc func()) {
var msg map[string]interface{}
if err := json.Unmarshal(message, &msg); err != nil {
log.Printf("[WebSocket] Failed to parse message: %v", err)
return
}
msgType, ok := msg["type"].(string)
if !ok {
return
}
switch msgType {
case "ping":
// Send pong response
pong, _ := json.Marshal(map[string]string{"type": "pong"})
if !safeSend(send, pong, done) {
return
}
case "subscribe":
sessionID, ok := msg["sessionId"].(string)
if !ok {
return
}
// Start streaming session data
go h.streamSession(sessionID, send, done)
case "unsubscribe":
// Currently we just close the connection when unsubscribing
closeFunc()
}
}
func (h *BufferWebSocketHandler) streamSession(sessionID string, send chan []byte, done chan struct{}) {
sess, err := h.manager.GetSession(sessionID)
if err != nil {
log.Printf("[WebSocket] Session not found: %v", err)
errorMsg, _ := json.Marshal(map[string]string{
"type": "error",
"message": fmt.Sprintf("Session not found: %v", err),
})
safeSend(send, errorMsg, done)
return
}
streamPath := sess.StreamOutPath()
// Check if stream file exists, wait a bit if it doesn't
maxRetries := 5
for i := 0; i < maxRetries; i++ {
if _, err := os.Stat(streamPath); err == nil {
break
}
if i == maxRetries-1 {
log.Printf("[WebSocket] Stream file not found after retries: %s", streamPath)
errorMsg, _ := json.Marshal(map[string]string{
"type": "error",
"message": "Session stream not available",
})
safeSend(send, errorMsg, done)
return
}
time.Sleep(100 * time.Millisecond)
}
// Create file watcher
watcher, err := fsnotify.NewWatcher()
if err != nil {
log.Printf("[WebSocket] Failed to create watcher: %v", err)
errorMsg, _ := json.Marshal(map[string]string{
"type": "error",
"message": "Failed to create file watcher",
})
safeSend(send, errorMsg, done)
return
}
defer watcher.Close()
// Add the stream file to the watcher
err = watcher.Add(streamPath)
if err != nil {
log.Printf("[WebSocket] Failed to watch file: %v", err)
errorMsg, _ := json.Marshal(map[string]string{
"type": "error",
"message": fmt.Sprintf("Failed to watch session stream: %v", err),
})
safeSend(send, errorMsg, done)
return
}
headerSent := false
seenBytes := int64(0)
// Send initial content
h.processAndSendContent(sessionID, streamPath, &headerSent, &seenBytes, send, done)
// Watch for changes
for {
select {
case <-done:
return
case event, ok := <-watcher.Events:
if !ok {
return
}
if event.Op&fsnotify.Write == fsnotify.Write {
h.processAndSendContent(sessionID, streamPath, &headerSent, &seenBytes, send, done)
}
case err, ok := <-watcher.Errors:
if !ok {
return
}
log.Printf("[WebSocket] Watcher error: %v", err)
case <-time.After(30 * time.Second):
// Check if session is still alive less frequently to reduce CPU usage
if !sess.IsAlive() {
// Send exit event
exitMsg := h.createBinaryMessage(sessionID, []byte(`{"type":"exit","code":0}`))
safeSend(send, exitMsg, done)
return
}
}
}
}
func (h *BufferWebSocketHandler) processAndSendContent(sessionID, streamPath string, headerSent *bool, seenBytes *int64, send chan []byte, done chan struct{}) {
file, err := os.Open(streamPath)
if err != nil {
log.Printf("[WebSocket] Failed to open stream file %s: %v", streamPath, err)
// Don't panic, just return gracefully
return
}
defer file.Close()
// Get current file size
fileInfo, err := file.Stat()
if err != nil {
return
}
currentSize := fileInfo.Size()
if currentSize <= *seenBytes {
return
}
// Seek to last position
if _, err := file.Seek(*seenBytes, 0); err != nil {
return
}
// Read new content
newContentSize := currentSize - *seenBytes
newContent := make([]byte, newContentSize)
bytesRead, err := file.Read(newContent)
if err != nil {
return
}
*seenBytes = currentSize
// Process content line by line
content := string(newContent[:bytesRead])
lines := strings.Split(content, "\n")
// Handle incomplete last line
endIndex := len(lines)
if !strings.HasSuffix(content, "\n") && len(lines) > 0 {
incompleteLineBytes := int64(len(lines[len(lines)-1]))
*seenBytes -= incompleteLineBytes
endIndex = len(lines) - 1
}
// Process complete lines
for i := 0; i < endIndex; i++ {
line := lines[i]
if line == "" {
continue
}
// Try to parse as header first
if !*headerSent {
var header protocol.AsciinemaHeader
if err := json.Unmarshal([]byte(line), &header); err == nil && header.Version > 0 {
*headerSent = true
// Send header as binary message
headerData, _ := json.Marshal(map[string]interface{}{
"type": "header",
"width": header.Width,
"height": header.Height,
})
msg := h.createBinaryMessage(sessionID, headerData)
if !safeSend(send, msg, done) {
return
}
continue
}
}
// Try to parse as event array [timestamp, type, data]
var eventArray []interface{}
if err := json.Unmarshal([]byte(line), &eventArray); err == nil && len(eventArray) == 3 {
timestamp, ok1 := eventArray[0].(float64)
eventType, ok2 := eventArray[1].(string)
data, ok3 := eventArray[2].(string)
if ok1 && ok2 && ok3 && eventType == "o" {
// Create terminal output message
outputData, _ := json.Marshal(map[string]interface{}{
"type": "output",
"timestamp": timestamp,
"data": data,
})
msg := h.createBinaryMessage(sessionID, outputData)
if !safeSend(send, msg, done) {
return
}
} else if ok1 && ok2 && ok3 && eventType == "r" {
// Create resize message
resizeData, _ := json.Marshal(map[string]interface{}{
"type": "resize",
"timestamp": timestamp,
"dimensions": data,
})
msg := h.createBinaryMessage(sessionID, resizeData)
if !safeSend(send, msg, done) {
return
}
}
}
}
}
func (h *BufferWebSocketHandler) createBinaryMessage(sessionID string, data []byte) []byte {
// Binary message format:
// [magic byte (1)] [session ID length (4, little endian)] [session ID] [data]
sessionIDBytes := []byte(sessionID)
totalLen := 1 + 4 + len(sessionIDBytes) + len(data)
msg := make([]byte, totalLen)
offset := 0
// Magic byte
msg[offset] = BufferMagicByte
offset++
// Session ID length (little endian)
binary.LittleEndian.PutUint32(msg[offset:], uint32(len(sessionIDBytes)))
offset += 4
// Session ID
copy(msg[offset:], sessionIDBytes)
offset += len(sessionIDBytes)
// Data
copy(msg[offset:], data)
return msg
}
func (h *BufferWebSocketHandler) writer(conn *websocket.Conn, send chan []byte, ticker *time.Ticker, done chan struct{}) {
defer close(send)
for {
select {
case message, ok := <-send:
conn.SetWriteDeadline(time.Now().Add(writeWait))
if !ok {
conn.WriteMessage(websocket.CloseMessage, []byte{})
return
}
// Check if it's a text message (JSON) or binary
if len(message) > 0 && message[0] == '{' {
// Text message
if err := conn.WriteMessage(websocket.TextMessage, message); err != nil {
return
}
} else {
// Binary message
if err := conn.WriteMessage(websocket.BinaryMessage, message); err != nil {
return
}
}
case <-ticker.C:
conn.SetWriteDeadline(time.Now().Add(writeWait))
if err := conn.WriteMessage(websocket.PingMessage, nil); err != nil {
return
}
case <-done:
return
}
}
}