Commit graph

176 commits

Author SHA1 Message Date
Matt Kiazyk
da56b2ac6d
Updates estimated time on info pane to 2 lines for better readability 2021-03-07 14:33:32 -06:00
Matt Kiazyk
f01db8b931
Increment build number
Signed-off-by: Matt Kiazyk <mattkiazyk@gmail.com>
2021-02-22 15:12:09 -06:00
Brandon Evans
22894e2d6d
Move installation step beside cancel button in info pane 2021-02-18 19:20:08 -07:00
Brandon Evans
2f04d23eac
Use Logger for Progress.updateFromAria2 2021-02-18 19:19:30 -07:00
Brandon Evans
899eec7dae
Don't attempt to parse days from aria2c ETA
I had initially suggested this but then went and checked in the source and the largest unit in the format is hours. 52da4e40ea/src/util.cc (L518-L534)
2021-02-18 19:16:08 -07:00
Brandon Evans
e301ad8818
Configure aria2c Progress better
Using .file kind and .downloading file operation kind will produce a more appropriate localizedAdditionalDescription.

The fileTotalCount and fileCompletedCount aren't appropriate for this case, because there's only one file being downloaded.
2021-02-18 19:14:44 -07:00
Brandon Evans
d00a356c29
Show installation step description for all steps in InstallationStepDetailView 2021-02-18 19:14:06 -07:00
Brandon Evans
1469dfa56b
Replace ObservingDownloadStatsView with ObservingProgressIndicator
This more closely replicates the default look and feel of SwiftUI.ProgressView, but with explicit control over whether localizedAdditionalDescription is shown and without the label above the progress view that displays a fileOperationKind string.
2021-02-18 19:10:12 -07:00
Matt Kiazyk
e638547900
add Percent text to bar 2021-02-15 13:14:52 -06:00
Matt Kiazyk
b06be4e3fa
Download stats for Aria2 2021-02-13 21:23:22 -06:00
Matt Kiazyk
2329098601
Merge pull request #104 from RobotsAndPencils/matt/FractionDownloadHelp
Moves the .help for the ProgressIndicator so it refreshes with the fraction change
2021-02-10 10:24:50 -06:00
Matt Kiazyk
80c02295be
fix typo
Co-authored-by: Sam Lu <sam.lu@robotsandpencils.com>
2021-02-10 08:12:56 -06:00
Brandon Evans
519df4e63c
Merge pull request #103 from RobotsAndPencils/fix-split-view
Remove info pane from split view instead of hiding it
2021-02-08 08:16:58 -07:00
Brandon Evans
9eda0984ac
Merge pull request #100 from RobotsAndPencils/identical-builds
Improve how identical builds are represented in the UI
2021-02-08 08:16:32 -07:00
Matt Kiazyk
f636651ba4
Moves the .help for the ProgressIndicator so it refreshes with the fraction change 2021-02-07 14:33:48 -06:00
Brandon Evans
1dd6232891
Remove InfoPane from split view instead of hiding it
When it was hidden the split view would still allow you to resize the remaining split, which resulted in weird behaviour. Instead, just remove the info pane split and the split view doesn't let you resize. Had to move where this global alert lives as a result because it might have to be presented even if the info pane isn't visible.

I tried changing the alert so it wasn't on the main window, and was instead local to the buttons that triggered its presentation, and this worked for all but the case where the CancelInstallButton was used from the Xcode menu. So for now I left it close to where it already was.
2021-02-06 18:28:05 -07:00
Brandon Evans
3208a4d8d2
Put InfoPane content in ScrollView
This issue was revealed when I broke the identical builds functionality with the Apple data source. https://github.com/RobotsAndPencils/XcodesApp/pull/100#pullrequestreview-584917125
2021-02-06 15:29:33 -07:00
Brandon Evans
b8bae4f32c
Don't consider versions without build identifiers for identical builds 2021-02-06 14:56:28 -07:00
Brandon Evans
ef646b7b88
Add identical builds indicator to XcodeListViewRow 2021-02-06 14:43:35 -07:00
Brandon Evans
70872f441a
Make XcodeListViewRow.appState a normal property
It doesn't need to be a DynamicProperty because it only invokes its methods.
2021-02-06 14:43:35 -07:00
Brandon Evans
70ca8c37bf
Add identical builds to the info pane 2021-02-06 14:43:35 -07:00
Matt Kiazyk
1c6efbbbb1
default to aria2 2021-02-06 14:31:46 -06:00
Matt Kiazyk
c6e3382d94
When downloading, use the downloader from userdefaults 2021-02-05 08:32:23 -06:00
Brandon Evans
760c9f300e
Handle duplicate 3.2.3 release builds
:/
2021-02-04 21:25:01 -07:00
Brandon Evans
dcd4001548
Merge identical builds into the release version instead of filtering 2021-02-04 21:25:00 -07:00
Brandon Evans
bc45daeb74
Only adjust available versions for Apple data source 2021-02-04 21:25:00 -07:00
Brandon Evans
7ac4814420
Treat GM versions as release versions 2021-02-04 21:25:00 -07:00
Brandon Evans
57767f6920
Fix RC capitalization 2021-02-04 21:25:00 -07:00
Matt Kiazyk
75cbd9550b
Adjust ByteCountFormatter. PR Feedback 2021-02-03 21:55:47 -06:00
Matt Kiazyk
b53c480764
Adds a DownloadFileSize when using Apple Data Source 2021-02-01 21:18:49 -06:00
Matt Kiazyk
385f740c42
Reset spm cache to correctly create license file 2021-01-28 17:20:23 -07:00
Matt Kiazyk
e6ee43a169
Preferences UI adjustments 2021-01-28 17:20:22 -07:00
Matt Kiazyk
a740b3be08
Remove Preferences dependency. Adjust Settings UI with groups 2021-01-27 21:38:22 -06:00
Matt Kiazyk
202212f417
Updates PreferencesView To use built in Settings Scene 2021-01-26 22:45:43 -06:00
Brandon Evans
bb28386306
Increment build number 2021-01-26 08:54:44 -07:00
Brandon Evans
352816f64a
Merge pull request #87 from RobotsAndPencils/auth-pref-ui-change
Show stored username in General preference pane even when we don't have a valid session
2021-01-26 08:50:18 -07:00
Brandon Evans
75457dd9eb
Show stored username in General preference pane
This reverts the change from 90c067997b so that the username is shown in situations where we don't have a valid session but could almost certainly get one. Instead, to achieve what that commit was trying to do, we'll instead remove the username from UserDefaults if auth fails with an invalid username or password error. I think this will more closely match what users expect in this UI.

I've added a comment in the UI explaining why it is the way it is. It might also be worth considering renaming AuthenticationState or its cases to better reflect that it's probably more about the (short-lived) session state than whether the user has signed in before and has stored their credentials.
2021-01-25 19:56:28 -07:00
Brandon Evans
58cddb88f6
Try to improve auth error messages 2021-01-25 19:36:49 -07:00
Brandon Evans
a04bfb39d0
Treat 400 from security code submission to be incorrect code 2021-01-25 19:23:51 -07:00
Brandon Evans
9508cda585
Remove invalid phone number index error
Not relevant for Xcodes.app.
2021-01-25 19:23:50 -07:00
Brandon Evans
6b5a64010e
Add bug report and feature request options to Help menu
This will support error messages that instruct the user to go to the Help menu for these things.
2021-01-25 19:23:50 -07:00
Brandon Evans
9a2057bcd5
Merge pull request #84 from RobotsAndPencils/prepare-user-for-helper-installation
Prepare user for helper installation before attempting to install
2021-01-25 18:33:48 -07:00
Brandon Evans
cb507c3d02
Prepare user for helper installation before post-install steps 2021-01-23 20:25:28 -07:00
Brandon Evans
044f066422
Extract HelperInstallState to new file 2021-01-23 19:38:11 -07:00
Brandon Evans
d84173e29c
Prepare user for helper installation
Doesn't yet handle the post-install steps that need the helper.
2021-01-23 19:38:11 -07:00
Matt Kiazyk
f970649bad
Merge pull request #81 from RobotsAndPencils/matt/progressToolTip
Show ToolTip on progress indicator
2021-01-23 17:29:27 -06:00
Matt Kiazyk
7fad56b3f7
Put tooltip on installationStepView 2021-01-23 17:13:07 -06:00
Brandon Evans
408d05a4a7
Merge pull request #80 from RobotsAndPencils/handle-helper-install-errors
Handle helper installation errors
2021-01-23 15:00:57 -07:00
Brandon Evans
6d2fce2078
Merge pull request #79 from RobotsAndPencils/not-enough-free-space-error
Catch and reword xip "not enough free space" error
2021-01-23 15:00:43 -07:00
Matt Kiazyk
102f3bbb58
Add comments about why we're using appStorage instead of sceneStorage
Co-authored-by: Brandon Evans <brandon.evans@robotsandpencils.com>
2021-01-23 15:45:52 -06:00