sjs/immich
1
0
Fork 0
mirror of https://github.com/samsonjs/immich.git synced 2026-04-27 15:07:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(server): don't expose source types in face creation api (#16381)

Browse source 
* don't expose source types in face creation api

* update open-api

* remove source type reference from web
This commit is contained in:
Mert 2025-02-27 17:17:07 +03:00 committed by GitHub
parent 967c69317b
commit 7d6cfd09e6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 3 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
mobile/openapi/lib/model/asset_face_create_dto.dart generated
View file

Binary file not shown.

9
open-api/immich-openapi-specs.json
View file

@ -8301,14 +8301,6 @@
"format": "uuid", "format": "uuid",
"type": "string" "type": "string"
}, },
"sourceType": {
"allOf": [
{
"$ref": "#/components/schemas/SourceType"
}
],
"default": "manual"
},
"width": { "width": {
"type": "integer" "type": "integer"
}, },
@ -8325,7 +8317,6 @@
"imageHeight", "imageHeight",
"imageWidth", "imageWidth",
"personId", "personId",
"sourceType",
"width", "width",
"x", "x",
"y" "y"

1
open-api/typescript-sdk/src/fetch-client.ts
View file

@ -529,7 +529,6 @@ export type AssetFaceCreateDto = {
imageHeight: number; imageHeight: number;
imageWidth: number; imageWidth: number;
personId: string; personId: string;
sourceType: SourceType;
width: number; width: number;
x: number; x: number;
y: number; y: number;

6
server/src/dtos/person.dto.ts
View file

@ -1,6 +1,6 @@
import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger'; import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
import { Type } from 'class-transformer'; import { Type } from 'class-transformer';
import { IsArray, IsEnum, IsInt, IsNotEmpty, IsNumber, IsString, Max, Min, ValidateNested } from 'class-validator'; import { IsArray, IsInt, IsNotEmpty, IsNumber, IsString, Max, Min, ValidateNested } from 'class-validator';
import { DateTime } from 'luxon'; import { DateTime } from 'luxon';
import { PropertyLifecycle } from 'src/decorators'; import { PropertyLifecycle } from 'src/decorators';
import { AuthDto } from 'src/dtos/auth.dto'; import { AuthDto } from 'src/dtos/auth.dto';
@ -194,10 +194,6 @@ export class AssetFaceCreateDto extends AssetFaceUpdateItem {
@IsNotEmpty() @IsNotEmpty()
@IsNumber() @IsNumber()
height!: number; height!: number;
@ApiProperty({ type: 'string', enum: SourceType, enumName: 'SourceType' })
@IsEnum(SourceType)
sourceType: SourceType = SourceType.MANUAL;
} }
export class AssetFaceDeleteDto { export class AssetFaceDeleteDto {

2
server/src/services/person.service.ts
View file

@ -736,7 +736,7 @@ export class PersonService extends BaseService {
boundingBoxX2: dto.x + dto.width, boundingBoxX2: dto.x + dto.width,
boundingBoxY1: dto.y, boundingBoxY1: dto.y,
boundingBoxY2: dto.y + dto.height, boundingBoxY2: dto.y + dto.height,
sourceType: dto.sourceType, sourceType: SourceType.MANUAL,
}); });
} }

3
web/src/lib/components/asset-viewer/face-editor/face-editor.svelte
View file

@ -4,7 +4,7 @@
import { notificationController } from '$lib/components/shared-components/notification/notification'; import { notificationController } from '$lib/components/shared-components/notification/notification';
import { isFaceEditMode } from '$lib/stores/face-edit.svelte'; import { isFaceEditMode } from '$lib/stores/face-edit.svelte';
import { getPeopleThumbnailUrl } from '$lib/utils'; import { getPeopleThumbnailUrl } from '$lib/utils';
import { getAllPeople, createFace, type PersonResponseDto, SourceType } from '@immich/sdk'; import { getAllPeople, createFace, type PersonResponseDto } from '@immich/sdk';
import { Button } from '@immich/ui'; import { Button } from '@immich/ui';
import { Canvas, InteractiveFabricObject, Rect } from 'fabric'; import { Canvas, InteractiveFabricObject, Rect } from 'fabric';
import { onMount } from 'svelte'; import { onMount } from 'svelte';
@ -288,7 +288,6 @@
assetFaceCreateDto: { assetFaceCreateDto: {
assetId, assetId,
personId: person.id, personId: person.id,
sourceType: SourceType.Manual,
...data, ...data,
}, },
}); });