sjs/media
1
0
Fork 0
mirror of https://github.com/samsonjs/media.git synced 2026-04-27 15:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove subtitle TODO from CapturingRenderersFactory

Browse source 
We're moving towards parsing subtitles before the `SampleQueue`, and we
already have subtitle playback assertions using `Player.Listener.onCues`
which is the most 'complete' place to assert subtitle output from. We
don't need to hook anything inside `TextRenderer`, so we can remove this
TODO.

PiperOrigin-RevId: 561418660
This commit is contained in:
ibaker 2023-08-30 12:36:19 -07:00 committed by Copybara-Service
parent ba4b96d2c1
commit 147cab89c3
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libraries/test_utils/src/main/java/androidx/media3/test/utils/CapturingRenderersFactory.java
View file

@ -62,8 +62,6 @@ import java.util.concurrent.atomic.AtomicBoolean;
* <p>The captured interactions can be used in a test assertion via the {@link Dumper.Dumpable} * <p>The captured interactions can be used in a test assertion via the {@link Dumper.Dumpable}
* interface. * interface.
*/ */
// TODO(internal b/174661563): Add support for capturing subtitles on the output of the
// SubtitleDecoder. And possibly Metadata too (for consistency).
@UnstableApi @UnstableApi
public class CapturingRenderersFactory implements RenderersFactory, Dumper.Dumpable { public class CapturingRenderersFactory implements RenderersFactory, Dumper.Dumpable {