Gonzalo Rodriguez
3ed014d45a
Merge pull request #373 from grzuy/jruby
...
Stop running TravisCI against jRuby for now
2018-07-02 18:57:39 -03:00
Gonzalo Rodriguez
db10436452
Update CHANGELOG
2018-07-02 14:26:56 -03:00
Gonzalo Rodriguez
eaaa60ec44
Stop running TravisCI against jRuby for now
...
I am starting to find it difficult to argue in favor of having jruby in
the list of TravisCI rubies.
It adds a bit of extra cost in maintenance and time spent waiting build to finish,
without feeling we're getting a lot out of it. Thus, the feeling is that it has low ROI.
Reasons behind my feeling of not "getting a lot out of it" includes:
- Almost never coming across a situation in which I thought to myself
"Hey, with this change we're making the gem incompatible with jRuby" because most
of the failures on jRuby builds where either heisenbugs and/or rvm installation
problems with jRuby, at least in my experience
- Usage share seems to be very very low, even compared to unmaintaned
MRI version, according to some sources, e.g.
https://semaphoreci.com/blog/2017/11/08/ruby-versions-used-in-commercial-projects-in-2017.html
2018-07-02 14:09:17 -03:00
Gonzalo Rodriguez
e4a8c1ce1f
Merge pull request #369 from grzuy/test_plain_redis
...
Acceptance test plain redis as a cache store backend
2018-06-29 17:23:10 -03:00
Gonzalo Rodriguez
e295ede874
Use RedisStoreProxy (not RedisProxy) for Redis::Store
2018-06-29 16:48:40 -03:00
Gonzalo Rodriguez
673cf98157
Avoid as much repetition as possible between RedisProxy and RedisStoreProxy
2018-06-29 15:44:41 -03:00
Gonzalo Rodriguez
b40b5718dc
rubocop --auto-correct
2018-06-29 15:41:36 -03:00
Gonzalo Rodriguez
e50bfbebaa
Acceptance test plain redis as a cache store backend
2018-06-29 15:41:04 -03:00
Gonzalo Rodriguez
6fbb6c8b1c
Merge branch 'master' into support-redis-gem
2018-06-29 15:40:45 -03:00
Gonzalo Rodriguez
3634f79e3d
Merge pull request #356 from grzuy/spec_helper_requires
...
Remove unnecessary requires in spec_helper
2018-06-29 15:30:08 -03:00
Gonzalo Rodriguez
eb07d9789f
Prefer Gem::Version for version comparisons
2018-06-29 15:27:36 -03:00
Gonzalo Rodriguez
85c4c085c9
Remove duplicated #initialize
2018-06-29 15:27:20 -03:00
Gonzalo Rodriguez
d1682b19b4
Merge remote-tracking branch 'rfwatson/master'
2018-06-29 15:24:13 -03:00
Gonzalo Rodriguez
aca4078089
Remove unnecessary requires in spec_helper
2018-06-29 11:47:04 -03:00
Gonzalo Rodriguez
73bc739d5a
Merge remote-tracking branch 'doliveirakn/master'
2018-06-29 11:17:19 -03:00
Gonzalo Rodriguez
19e17562c1
Merge pull request #372 from grzuy/drop_deprecated_methods
...
Remove previously deprecated public methods
2018-06-28 19:12:41 -03:00
Gonzalo Rodriguez
7458023644
Merge pull request #365 from grzuy/remove_ruby_2_2
...
Remove support for unmaintained ruby 2.2
2018-06-28 18:15:24 -03:00
Gonzalo Rodriguez
1c1ee918e1
Remove previously deprecated public methods
2018-06-28 17:16:33 -03:00
Gonzalo Rodriguez
8315a1e7e1
Remove support for unmaintained ruby 2.2
2018-06-28 17:08:15 -03:00
Gonzalo Rodriguez
8802ebfbaf
Merge branch '255-correct-object-for-instrumentation'
2018-06-28 16:40:08 -03:00
Gonzalo Rodriguez
83127dcf6d
Merge pull request #367 from grzuy/clean_dev_deps
...
More cleaning of development dependencies
2018-06-26 14:54:16 -03:00
Gonzalo Rodriguez
596ddabb0f
Fix rubocop Bundler/OrderedGems offenses
2018-06-26 13:38:16 -03:00
Gonzalo Rodriguez
cb297b40b9
Merge pull request #368 from grzuy/clean_runtime_deps
...
Make rack dependency constraint more explicit
2018-06-26 13:35:30 -03:00
Gonzalo Rodriguez
6a52e0e070
Fix 'WARNING: open-ended dependency on rack (>= 1.0) is not recommended'
2018-06-26 11:40:19 -03:00
Gonzalo Rodriguez
d511c9e2ba
Make explicit that old rack 0.x is not supported
2018-06-26 11:30:13 -03:00
Gonzalo Rodriguez
9e2fef7abe
Make clear that bundler is a development depdendency
2018-06-26 11:20:57 -03:00
Gonzalo Rodriguez
3c37390c63
Run with latest activesupport/actionpack when developing
2018-06-26 11:15:13 -03:00
Gonzalo Rodriguez
48af653531
Merge pull request #366 from grzuy/clearer_test_output
...
Make test run output a bit more clear by collapsing runs
2018-06-26 10:56:32 -03:00
Gonzalo Rodriguez
eafc13f44a
Make test run output a bit more clear by collapsing 3 separate runs into just 1
2018-06-26 09:50:40 -03:00
Gonzalo Rodriguez
21561bb2f5
Bump version to v5.3.2
2018-06-25 19:27:35 -03:00
Gonzalo Rodriguez
01e8bf640a
Merge pull request #364 from grzuy/dont_require_redis_for_memory_store
...
[Fixes #355 ] Don't require redis if not necessary
2018-06-25 19:05:59 -03:00
Gonzalo Rodriguez
ee84079768
Fix 'redis is not part of the bundle' exception when using :memory_store
...
When RedisCacheStore constant is referenced, activesupport autoloads and
rails tries to require redis, throwing exception if not present
2018-06-25 17:42:45 -03:00
Gonzalo Rodriguez
7b119da8c8
Merge pull request #363 from grzuy/ruby_2-6
...
Update ruby 2.6 for TravisCI runs
2018-06-25 16:31:40 -03:00
Gonzalo Rodriguez
e3213ee746
Fix .travis.yml gemfile paths
2018-06-25 16:15:02 -03:00
Gonzalo Rodriguez
0d338227f0
Update ruby 2.6 for TravisCI runs
2018-06-25 14:13:25 -03:00
Gonzalo Rodriguez
5d48addd6e
Make TravisCI run new appraisal scenarios
2018-06-22 19:20:46 -03:00
Gonzalo Rodriguez
a4b605e307
Merge branch 'master' into test_cache_store_dependencies_in_isolation
2018-06-22 19:14:28 -03:00
Gonzalo Rodriguez
a1ea2f9aef
Avoid repetition in spec_helper
2018-06-22 19:04:47 -03:00
Gonzalo Rodriguez
a72bfb5fc7
Only require redis stores when running their respective appraisal
2018-06-22 18:55:27 -03:00
Gonzalo Rodriguez
b6362415ba
Merge pull request #360 from grzuy/test_cache_store
...
Acceptance test supported cache store backends
2018-06-22 18:17:59 -03:00
Gonzalo Rodriguez
bd2ade8977
Only require connection_pool running connection_pool appraisal
2018-06-22 17:45:58 -03:00
Gonzalo Rodriguez
79de0d53e1
Only require dalli when running dalli appraisal
2018-06-22 17:45:03 -03:00
Gonzalo Rodriguez
55444b456d
Merge pull request #361 from grzuy/clean_dev_deps
...
Remove unused development dependency (memcache-client)
2018-06-22 17:06:51 -03:00
Gonzalo Rodriguez
93fc1641ea
Merge branch 'clean_dev_deps' into dont_require_redis_for_memory_store
2018-06-22 16:33:31 -03:00
Gonzalo Rodriguez
1a532c6cb3
Remove unused development dependency (memcache-client)
2018-06-22 16:17:44 -03:00
Gonzalo Rodriguez
9cc49b4760
Acceptance test ConnectionPool with Dalli::Client (via connection_pool and dalli) as cache store backend
2018-06-22 14:59:44 -03:00
Gonzalo Rodriguez
bcc1f5857e
Acceptance test ActiveSupport::Cache::MemoryStore (via activesupport) as cache store backend
2018-06-22 14:58:00 -03:00
Gonzalo Rodriguez
1f05ff30d5
Fix namespace of test file names
2018-06-22 14:55:22 -03:00
Gonzalo Rodriguez
831e4e9e97
Acceptance test Dalli::Client (via dalli) as cache store backend
2018-06-22 14:55:22 -03:00
Gonzalo Rodriguez
bca253c674
Acceptance test ActiveSupport::Cache::DalliStore (via dalli) as cache store backend
2018-06-22 14:54:46 -03:00
