Gonzalo Rodriguez
596ddabb0f
Fix rubocop Bundler/OrderedGems offenses
2018-06-26 13:38:16 -03:00
Gonzalo Rodriguez
9e2fef7abe
Make clear that bundler is a development depdendency
2018-06-26 11:20:57 -03:00
Gonzalo Rodriguez
3c37390c63
Run with latest activesupport/actionpack when developing
2018-06-26 11:15:13 -03:00
Gonzalo Rodriguez
48af653531
Merge pull request #366 from grzuy/clearer_test_output
...
Make test run output a bit more clear by collapsing runs
2018-06-26 10:56:32 -03:00
Gonzalo Rodriguez
eafc13f44a
Make test run output a bit more clear by collapsing 3 separate runs into just 1
2018-06-26 09:50:40 -03:00
Gonzalo Rodriguez
21561bb2f5
Bump version to v5.3.2
2018-06-25 19:27:35 -03:00
Gonzalo Rodriguez
01e8bf640a
Merge pull request #364 from grzuy/dont_require_redis_for_memory_store
...
[Fixes #355 ] Don't require redis if not necessary
2018-06-25 19:05:59 -03:00
Gonzalo Rodriguez
ee84079768
Fix 'redis is not part of the bundle' exception when using :memory_store
...
When RedisCacheStore constant is referenced, activesupport autoloads and
rails tries to require redis, throwing exception if not present
2018-06-25 17:42:45 -03:00
Gonzalo Rodriguez
7b119da8c8
Merge pull request #363 from grzuy/ruby_2-6
...
Update ruby 2.6 for TravisCI runs
2018-06-25 16:31:40 -03:00
Gonzalo Rodriguez
e3213ee746
Fix .travis.yml gemfile paths
2018-06-25 16:15:02 -03:00
Gonzalo Rodriguez
0d338227f0
Update ruby 2.6 for TravisCI runs
2018-06-25 14:13:25 -03:00
Gonzalo Rodriguez
5d48addd6e
Make TravisCI run new appraisal scenarios
2018-06-22 19:20:46 -03:00
Gonzalo Rodriguez
a4b605e307
Merge branch 'master' into test_cache_store_dependencies_in_isolation
2018-06-22 19:14:28 -03:00
Gonzalo Rodriguez
a1ea2f9aef
Avoid repetition in spec_helper
2018-06-22 19:04:47 -03:00
Gonzalo Rodriguez
a72bfb5fc7
Only require redis stores when running their respective appraisal
2018-06-22 18:55:27 -03:00
Gonzalo Rodriguez
b6362415ba
Merge pull request #360 from grzuy/test_cache_store
...
Acceptance test supported cache store backends
2018-06-22 18:17:59 -03:00
Gonzalo Rodriguez
bd2ade8977
Only require connection_pool running connection_pool appraisal
2018-06-22 17:45:58 -03:00
Gonzalo Rodriguez
79de0d53e1
Only require dalli when running dalli appraisal
2018-06-22 17:45:03 -03:00
Gonzalo Rodriguez
55444b456d
Merge pull request #361 from grzuy/clean_dev_deps
...
Remove unused development dependency (memcache-client)
2018-06-22 17:06:51 -03:00
Gonzalo Rodriguez
93fc1641ea
Merge branch 'clean_dev_deps' into dont_require_redis_for_memory_store
2018-06-22 16:33:31 -03:00
Gonzalo Rodriguez
1a532c6cb3
Remove unused development dependency (memcache-client)
2018-06-22 16:17:44 -03:00
Gonzalo Rodriguez
9cc49b4760
Acceptance test ConnectionPool with Dalli::Client (via connection_pool and dalli) as cache store backend
2018-06-22 14:59:44 -03:00
Gonzalo Rodriguez
bcc1f5857e
Acceptance test ActiveSupport::Cache::MemoryStore (via activesupport) as cache store backend
2018-06-22 14:58:00 -03:00
Gonzalo Rodriguez
1f05ff30d5
Fix namespace of test file names
2018-06-22 14:55:22 -03:00
Gonzalo Rodriguez
831e4e9e97
Acceptance test Dalli::Client (via dalli) as cache store backend
2018-06-22 14:55:22 -03:00
Gonzalo Rodriguez
bca253c674
Acceptance test ActiveSupport::Cache::DalliStore (via dalli) as cache store backend
2018-06-22 14:54:46 -03:00
Gonzalo Rodriguez
93b1bf4c86
Acceptance test Redis::Store (redis-store) as cache store backend
2018-06-22 14:53:06 -03:00
Gonzalo Rodriguez
92f3b7fbd0
Acceptance test ActiveSupport::Cache::RedisStore (redis-activesupport) as cache store backend
2018-06-22 14:53:05 -03:00
Gonzalo Rodriguez
3f590e4774
Acceptance tests already cover integration with RedisCacheStore and MemCacheStore
2018-06-22 14:51:38 -03:00
Gonzalo Rodriguez
5aedc05121
Merge pull request #359 from grzuy/clean_dev_deps
...
Clean development dependencies
2018-06-22 12:07:18 -03:00
Gonzalo Rodriguez
9257e40b96
Make rack-test compatible again with actionpack for some appraisals runs
2018-06-21 17:40:44 -03:00
Gonzalo Rodriguez
d25c490694
Merge pull request #358 from grzuy/gemspec
...
Add useful metadata links to rubygems.org via gemspec
2018-06-21 16:05:47 -03:00
Gonzalo Rodriguez
7a4b206dfd
Let everyone developing rack-attack use compatible/simiar dev deps versions
2018-06-21 15:56:33 -03:00
Gonzalo Rodriguez
aca0fb6f1d
Clarify in gemspec existence of two group of semantically distict dev deps
2018-06-21 15:56:33 -03:00
Gonzalo Rodriguez
0c26efc187
Remove pry as a dev dependency. Using byebug.
2018-06-21 15:56:33 -03:00
Gonzalo Rodriguez
75ed952d43
Remove guard-minitest as a dev dependency
2018-06-21 15:56:24 -03:00
Gonzalo Rodriguez
08861f8d17
Attempt to improve code legibility/clarity/semantics ( #357 )
...
* attempt to improve semantics for legibility
* Attempt to improve legibility by simplifying
* Make it more clear that we're calling procs/blocks here
* Enable rubocop Style/BlockDelimiters cop
* Prefer 'request' over 'req' abbreviation for legibility/clarity
* Instances of Track named 'track' not 'tracker'
2018-06-21 14:33:24 -03:00
Gonzalo Rodriguez
1504a1f00c
Add useful metadata links to rubygems.org via gemspec
2018-06-21 11:39:35 -03:00
Gonzalo Rodriguez
d8b88cfb84
Honor amount argument instead of hard coding counter (part 2)
...
See commit ca2e752937
2018-06-21 11:25:47 -03:00
Gonzalo Rodriguez
196868130a
Bump version to v5.3.1
2018-06-20 19:49:15 -03:00
Gonzalo Rodriguez
8969d16aca
Merge pull request #354 from grzuy/redis_cache_store_pooled
...
Pooled RedisCacheStore as a backend store
2018-06-20 19:38:34 -03:00
Gonzalo Rodriguez
2c1cbc323e
Default increment amount to 1 as RedisCacheStore
2018-06-20 19:14:37 -03:00
Gonzalo Rodriguez
ca2e752937
Honor amount argument instead of hard coding counter
2018-06-20 19:14:02 -03:00
Gonzalo Rodriguez
3af7394b6a
Refactor RedisCacheStoreProxy to unlearn everything about redis client details to make it less prone to bugs in the future
...
Let RedisCacheStoreProxy only know and assume things about
RedisCacheStore API. Don't let it know anything about the specific redis
client behind the scenes, that's the job of RedisCacheStore only, not
ours.
2018-06-20 18:33:00 -03:00
Alexey Vasiliev
3caee5c3ca
Fix usage of RedisCacheStore for rails 5.2.0
2018-06-20 18:06:45 -03:00
Gonzalo Rodriguez
e830804586
Acceptance test pooled RedisCacheStore as a backend store
2018-06-20 17:47:21 -03:00
Gonzalo Rodriguez
f2a3a25e98
Merge pull request #351 from grzuy/style
...
Enabled more rubocop cops
2018-06-20 15:08:42 -03:00
Gonzalo Rodriguez
326ab8e098
Temporary fix for rubocop during CI builds
2018-06-20 14:25:49 -03:00
Gonzalo Rodriguez
d5e585680f
Fix CircleCI rubocop runs by excluding vendor/ folder
...
rubocop default configuration exclude vendor/ folder, but in order to
get the default we need to merge arrays, given that we are also setting
Exclude
2018-06-20 10:29:19 -03:00
Gonzalo Rodriguez
86eb9f9e0a
Enable Style/BracesAroundHashParameters rubocop cop
2018-06-19 17:57:30 -03:00
