Gonzalo Rodriguez
a72bfb5fc7
Only require redis stores when running their respective appraisal
2018-06-22 18:55:27 -03:00
Gonzalo Rodriguez
bd2ade8977
Only require connection_pool running connection_pool appraisal
2018-06-22 17:45:58 -03:00
Gonzalo Rodriguez
79de0d53e1
Only require dalli when running dalli appraisal
2018-06-22 17:45:03 -03:00
Gonzalo Rodriguez
93fc1641ea
Merge branch 'clean_dev_deps' into dont_require_redis_for_memory_store
2018-06-22 16:33:31 -03:00
Gonzalo Rodriguez
1a532c6cb3
Remove unused development dependency (memcache-client)
2018-06-22 16:17:44 -03:00
Gonzalo Rodriguez
9cc49b4760
Acceptance test ConnectionPool with Dalli::Client (via connection_pool and dalli) as cache store backend
2018-06-22 14:59:44 -03:00
Gonzalo Rodriguez
bcc1f5857e
Acceptance test ActiveSupport::Cache::MemoryStore (via activesupport) as cache store backend
2018-06-22 14:58:00 -03:00
Gonzalo Rodriguez
1f05ff30d5
Fix namespace of test file names
2018-06-22 14:55:22 -03:00
Gonzalo Rodriguez
831e4e9e97
Acceptance test Dalli::Client (via dalli) as cache store backend
2018-06-22 14:55:22 -03:00
Gonzalo Rodriguez
bca253c674
Acceptance test ActiveSupport::Cache::DalliStore (via dalli) as cache store backend
2018-06-22 14:54:46 -03:00
Gonzalo Rodriguez
93b1bf4c86
Acceptance test Redis::Store (redis-store) as cache store backend
2018-06-22 14:53:06 -03:00
Gonzalo Rodriguez
92f3b7fbd0
Acceptance test ActiveSupport::Cache::RedisStore (redis-activesupport) as cache store backend
2018-06-22 14:53:05 -03:00
Gonzalo Rodriguez
3f590e4774
Acceptance tests already cover integration with RedisCacheStore and MemCacheStore
2018-06-22 14:51:38 -03:00
Gonzalo Rodriguez
5aedc05121
Merge pull request #359 from grzuy/clean_dev_deps
...
Clean development dependencies
2018-06-22 12:07:18 -03:00
Gonzalo Rodriguez
9257e40b96
Make rack-test compatible again with actionpack for some appraisals runs
2018-06-21 17:40:44 -03:00
Gonzalo Rodriguez
d25c490694
Merge pull request #358 from grzuy/gemspec
...
Add useful metadata links to rubygems.org via gemspec
2018-06-21 16:05:47 -03:00
Gonzalo Rodriguez
7a4b206dfd
Let everyone developing rack-attack use compatible/simiar dev deps versions
2018-06-21 15:56:33 -03:00
Gonzalo Rodriguez
aca0fb6f1d
Clarify in gemspec existence of two group of semantically distict dev deps
2018-06-21 15:56:33 -03:00
Gonzalo Rodriguez
0c26efc187
Remove pry as a dev dependency. Using byebug.
2018-06-21 15:56:33 -03:00
Gonzalo Rodriguez
75ed952d43
Remove guard-minitest as a dev dependency
2018-06-21 15:56:24 -03:00
Gonzalo Rodriguez
08861f8d17
Attempt to improve code legibility/clarity/semantics ( #357 )
...
* attempt to improve semantics for legibility
* Attempt to improve legibility by simplifying
* Make it more clear that we're calling procs/blocks here
* Enable rubocop Style/BlockDelimiters cop
* Prefer 'request' over 'req' abbreviation for legibility/clarity
* Instances of Track named 'track' not 'tracker'
2018-06-21 14:33:24 -03:00
Gonzalo Rodriguez
1504a1f00c
Add useful metadata links to rubygems.org via gemspec
2018-06-21 11:39:35 -03:00
Gonzalo Rodriguez
d8b88cfb84
Honor amount argument instead of hard coding counter (part 2)
...
See commit ca2e752937
2018-06-21 11:25:47 -03:00
Gonzalo Rodriguez
196868130a
Bump version to v5.3.1
2018-06-20 19:49:15 -03:00
Gonzalo Rodriguez
8969d16aca
Merge pull request #354 from grzuy/redis_cache_store_pooled
...
Pooled RedisCacheStore as a backend store
2018-06-20 19:38:34 -03:00
Gonzalo Rodriguez
2c1cbc323e
Default increment amount to 1 as RedisCacheStore
2018-06-20 19:14:37 -03:00
Gonzalo Rodriguez
ca2e752937
Honor amount argument instead of hard coding counter
2018-06-20 19:14:02 -03:00
Gonzalo Rodriguez
3af7394b6a
Refactor RedisCacheStoreProxy to unlearn everything about redis client details to make it less prone to bugs in the future
...
Let RedisCacheStoreProxy only know and assume things about
RedisCacheStore API. Don't let it know anything about the specific redis
client behind the scenes, that's the job of RedisCacheStore only, not
ours.
2018-06-20 18:33:00 -03:00
Alexey Vasiliev
3caee5c3ca
Fix usage of RedisCacheStore for rails 5.2.0
2018-06-20 18:06:45 -03:00
Gonzalo Rodriguez
e830804586
Acceptance test pooled RedisCacheStore as a backend store
2018-06-20 17:47:21 -03:00
Gonzalo Rodriguez
f2a3a25e98
Merge pull request #351 from grzuy/style
...
Enabled more rubocop cops
2018-06-20 15:08:42 -03:00
Gonzalo Rodriguez
326ab8e098
Temporary fix for rubocop during CI builds
2018-06-20 14:25:49 -03:00
Gonzalo Rodriguez
d5e585680f
Fix CircleCI rubocop runs by excluding vendor/ folder
...
rubocop default configuration exclude vendor/ folder, but in order to
get the default we need to merge arrays, given that we are also setting
Exclude
2018-06-20 10:29:19 -03:00
Gonzalo Rodriguez
86eb9f9e0a
Enable Style/BracesAroundHashParameters rubocop cop
2018-06-19 17:57:30 -03:00
Gonzalo Rodriguez
1e9d601483
Run rubocop checks when running rake default task
2018-06-19 17:57:30 -03:00
Gonzalo Rodriguez
e6854bcb02
Enable rubocop Naming cops
2018-06-19 17:57:26 -03:00
Gonzalo Rodriguez
972a19006a
Enable a couple of rubocop Style cops
2018-06-19 17:25:36 -03:00
Gonzalo Rodriguez
60300145d8
Enable rubocop Lint cops
2018-06-19 17:19:49 -03:00
Gonzalo Rodriguez
dac926cf68
Bump version to v5.3.0
2018-06-19 15:49:20 -03:00
Gonzalo Rodriguez
2cdba6f5fa
Merge pull request #350 from grzuy/cache_key_leak
...
[Fixes #349 ] Don't leak cache keys
2018-06-19 15:24:41 -03:00
Gonzalo Rodriguez
7438e5122e
Non-leak acceptance test should only care about presence, not exact value
2018-06-19 14:00:20 -03:00
Brian Kephart
4cc8d7d854
Support ActiveSupport::RedisCacheStore
2018-06-19 13:39:43 -03:00
Gonzalo Rodriguez
d831f2490e
Acceptance test RedisCacheStore as a store backend doesn't leak keys
2018-06-19 12:12:45 -03:00
Gonzalo Rodriguez
8f3bf216db
Acceptance test MemCacheStore as a store backend doesn't leak keys
2018-06-19 11:37:08 -03:00
Gonzalo Rodriguez
1942ab39ca
Merge pull request #343 from grzuy/acceptance_test_stores
...
Acceptance test use of ActiveSupport::Cache::MemCacheStore
2018-05-21 09:58:35 -03:00
Gonzalo Rodriguez
e312f006b6
Merge pull request #344 from grzuy/clear_configuration
...
Avoid user confusion by renaming .clear! to .clear_configuration
2018-05-21 09:58:03 -03:00
Gonzalo Rodriguez
a99722bf4b
Avoid user confusion by renaming .clear! to .clear_configuration
2018-05-18 18:23:59 -03:00
Gonzalo Rodriguez
379cd39dc9
Acceptance test use of ActiveSupport::Cache::MemCacheStore
2018-05-18 14:10:07 -03:00
Gonzalo Rodriguez
cf672d60c1
Merge pull request #341 from grzuy/acceptance_test_redis_cache_store
...
Acceptance test use of ActiveSupport::Cache::RedisCacheStore
2018-05-18 11:17:33 -03:00
Gonzalo Rodriguez
8ca804e668
Acceptance test use of ActiveSupport::Cache::RedisCacheStore
2018-05-17 13:44:52 -03:00
