Gonzalo Rodriguez
aca0fb6f1d
Clarify in gemspec existence of two group of semantically distict dev deps
2018-06-21 15:56:33 -03:00
Gonzalo Rodriguez
0c26efc187
Remove pry as a dev dependency. Using byebug.
2018-06-21 15:56:33 -03:00
Gonzalo Rodriguez
75ed952d43
Remove guard-minitest as a dev dependency
2018-06-21 15:56:24 -03:00
Gonzalo Rodriguez
08861f8d17
Attempt to improve code legibility/clarity/semantics ( #357 )
...
* attempt to improve semantics for legibility
* Attempt to improve legibility by simplifying
* Make it more clear that we're calling procs/blocks here
* Enable rubocop Style/BlockDelimiters cop
* Prefer 'request' over 'req' abbreviation for legibility/clarity
* Instances of Track named 'track' not 'tracker'
2018-06-21 14:33:24 -03:00
Gonzalo Rodriguez
d8b88cfb84
Honor amount argument instead of hard coding counter (part 2)
...
See commit ca2e752937
2018-06-21 11:25:47 -03:00
Gonzalo Rodriguez
196868130a
Bump version to v5.3.1
2018-06-20 19:49:15 -03:00
Gonzalo Rodriguez
8969d16aca
Merge pull request #354 from grzuy/redis_cache_store_pooled
...
Pooled RedisCacheStore as a backend store
2018-06-20 19:38:34 -03:00
Gonzalo Rodriguez
2c1cbc323e
Default increment amount to 1 as RedisCacheStore
2018-06-20 19:14:37 -03:00
Gonzalo Rodriguez
ca2e752937
Honor amount argument instead of hard coding counter
2018-06-20 19:14:02 -03:00
Gonzalo Rodriguez
3af7394b6a
Refactor RedisCacheStoreProxy to unlearn everything about redis client details to make it less prone to bugs in the future
...
Let RedisCacheStoreProxy only know and assume things about
RedisCacheStore API. Don't let it know anything about the specific redis
client behind the scenes, that's the job of RedisCacheStore only, not
ours.
2018-06-20 18:33:00 -03:00
Alexey Vasiliev
3caee5c3ca
Fix usage of RedisCacheStore for rails 5.2.0
2018-06-20 18:06:45 -03:00
Gonzalo Rodriguez
e830804586
Acceptance test pooled RedisCacheStore as a backend store
2018-06-20 17:47:21 -03:00
Gonzalo Rodriguez
f2a3a25e98
Merge pull request #351 from grzuy/style
...
Enabled more rubocop cops
2018-06-20 15:08:42 -03:00
Gonzalo Rodriguez
326ab8e098
Temporary fix for rubocop during CI builds
2018-06-20 14:25:49 -03:00
Gonzalo Rodriguez
d5e585680f
Fix CircleCI rubocop runs by excluding vendor/ folder
...
rubocop default configuration exclude vendor/ folder, but in order to
get the default we need to merge arrays, given that we are also setting
Exclude
2018-06-20 10:29:19 -03:00
Gonzalo Rodriguez
86eb9f9e0a
Enable Style/BracesAroundHashParameters rubocop cop
2018-06-19 17:57:30 -03:00
Gonzalo Rodriguez
1e9d601483
Run rubocop checks when running rake default task
2018-06-19 17:57:30 -03:00
Gonzalo Rodriguez
e6854bcb02
Enable rubocop Naming cops
2018-06-19 17:57:26 -03:00
Gonzalo Rodriguez
972a19006a
Enable a couple of rubocop Style cops
2018-06-19 17:25:36 -03:00
Gonzalo Rodriguez
60300145d8
Enable rubocop Lint cops
2018-06-19 17:19:49 -03:00
Gonzalo Rodriguez
dac926cf68
Bump version to v5.3.0
2018-06-19 15:49:20 -03:00
Gonzalo Rodriguez
2cdba6f5fa
Merge pull request #350 from grzuy/cache_key_leak
...
[Fixes #349 ] Don't leak cache keys
2018-06-19 15:24:41 -03:00
Gonzalo Rodriguez
7438e5122e
Non-leak acceptance test should only care about presence, not exact value
2018-06-19 14:00:20 -03:00
Brian Kephart
4cc8d7d854
Support ActiveSupport::RedisCacheStore
2018-06-19 13:39:43 -03:00
Gonzalo Rodriguez
d831f2490e
Acceptance test RedisCacheStore as a store backend doesn't leak keys
2018-06-19 12:12:45 -03:00
Gonzalo Rodriguez
8f3bf216db
Acceptance test MemCacheStore as a store backend doesn't leak keys
2018-06-19 11:37:08 -03:00
Gonzalo Rodriguez
1942ab39ca
Merge pull request #343 from grzuy/acceptance_test_stores
...
Acceptance test use of ActiveSupport::Cache::MemCacheStore
2018-05-21 09:58:35 -03:00
Gonzalo Rodriguez
e312f006b6
Merge pull request #344 from grzuy/clear_configuration
...
Avoid user confusion by renaming .clear! to .clear_configuration
2018-05-21 09:58:03 -03:00
Gonzalo Rodriguez
a99722bf4b
Avoid user confusion by renaming .clear! to .clear_configuration
2018-05-18 18:23:59 -03:00
Gonzalo Rodriguez
379cd39dc9
Acceptance test use of ActiveSupport::Cache::MemCacheStore
2018-05-18 14:10:07 -03:00
Gonzalo Rodriguez
cf672d60c1
Merge pull request #341 from grzuy/acceptance_test_redis_cache_store
...
Acceptance test use of ActiveSupport::Cache::RedisCacheStore
2018-05-18 11:17:33 -03:00
Gonzalo Rodriguez
8ca804e668
Acceptance test use of ActiveSupport::Cache::RedisCacheStore
2018-05-17 13:44:52 -03:00
Gonzalo Rodriguez
0476778a8a
Merge pull request #339 from brian-kephart/defined
...
Replace `const_defined?` with `defined?`
2018-05-15 10:51:25 -03:00
Brian Kephart
b5b4164967
replace const_defined? with defined?
2018-05-13 17:45:12 -05:00
Gonzalo Rodriguez
863cfe4057
Merge pull request #338 from grzuy/rubocop
...
Enable more codestyle checks
2018-04-17 21:28:37 -04:00
Gonzalo Rodriguez
52ec80692d
Enable Lint rubocop cops
2018-04-17 16:27:56 -04:00
Gonzalo Rodriguez
d01c3e61d4
Enforce every rack-attack contributor runs same rubocop version
2018-04-17 16:00:00 -04:00
Gonzalo Rodriguez
9faf6cd32b
Enable Security rubocop cops
2018-04-17 14:16:17 -04:00
Gonzalo Rodriguez
ef24d262c8
Enable Performance rubocop cops
2018-04-17 14:13:35 -04:00
Gonzalo Rodriguez
29424fb993
Enable Gemspec rubocop cops
...
Run rubocop against oldest supported ruby
2018-04-17 14:08:00 -04:00
Gonzalo Rodriguez
4491e32180
Enable Bundler rubocop cops
2018-04-17 01:03:13 -04:00
Gonzalo Rodriguez
bbc300a08f
Merge pull request #337 from grzuy/rails_5-2
...
Officially support rails 5.2
2018-04-10 15:34:17 -03:00
Gonzalo Rodriguez
8a6bb6bc5e
Drop support for rails 5.0, it's an unmaintained series now
2018-04-10 11:43:46 -04:00
Gonzalo Rodriguez
2e9eb6716f
Don't allow failures against rails 5.2, it's out now
2018-04-10 11:02:17 -04:00
Gonzalo Rodriguez
fec4f322d2
Merge pull request #336 from grzuy/test_against_rack_1_6
...
[Fixes #329 ] Be explicit about testing against supported rack versions
2018-04-10 12:01:33 -03:00
Gonzalo Rodriguez
a8200ea95a
Explicitly test against supported rack versions
2018-04-10 10:35:14 -04:00
Gonzalo Rodriguez
e7792aadd7
Remove obsolete piece of autogenerated appraisal gemfile
2018-04-10 10:33:26 -04:00
Spencer Norman
f56967f923
fixed spelling issue, returna to return ( #334 )
...
* fixed spelling issue, returna to returns
* fixed the spelling properly this time, returns to return
2018-04-06 10:19:53 -03:00
Gonzalo Rodriguez
63e330f794
Merge pull request #333 from lmansur/style-guide-in-contributing-guide
...
[Fixes #302 ] Add a section on Style Guide in the CONTRIBUTING file
2018-04-04 18:13:48 -03:00
Lucas Mansur
a6158b4358
Add a section on Style Guide in the CONTRIBUTING guide
2018-03-30 16:30:43 -03:00
