sjs/rack-attack
1
0
Fork 0
mirror of https://github.com/samsonjs/rack-attack.git synced 2026-03-25 09:25:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
388 commits 1 branch 0 tags 1.1 MiB
Commit graph

388 commits

This branch
This branch
All branches
Author SHA1 Message Date
Gonzalo Rodriguez
c9cd0239a4
Merge pull request #278 from grzuy/move_all_deps_to_gemspec 
Move all dependencies to gemspec out of Gemfile
 2018-03-09 11:38:31 -03:00
Gonzalo Rodriguez
922917d5a4
Merge pull request #274 from grzuy/help_debug_cache_issues 
Help users understand more clearly when the store is misconfigured
 2018-03-09 10:28:08 -03:00
Gonzalo Rodriguez
bed046ee75
Merge pull request #271 from grzuy/ruby_2-5 
[Fixes #253] Avoid 'defined?' buggy behavior in ruby 2.5.0
 2018-03-09 10:20:22 -03:00
Gonzalo Rodriguez
859c212058 Merge branch 'master' into move_all_deps_to_gemspec 2018-03-09 10:19:25 -03:00
Gonzalo Rodriguez
53b0561e7f
Merge pull request #272 from grzuy/rack_lint 
Use Rack::Lint in tests to check any change continues to comply with the rack spec
 2018-03-09 10:11:05 -03:00
Gonzalo Rodriguez
8603a3e056
Merge pull request #266 from grzuy/test_understandability 
Attempt to make it easier to understand that the method is making assertions
 2018-03-09 10:10:48 -03:00
Gonzalo Rodriguez
42cd957f2f
Merge pull request #276 from grzuy/rails_5-2 
Test against rails 5.2.0.rc to get early feedback
 2018-03-09 10:07:06 -03:00
Gonzalo Rodriguez
66909c6419
Merge pull request #269 from grzuy/acceptance_tests 
Adds acceptance-oriented tests
 2018-03-08 18:17:35 -03:00
Gonzalo Rodriguez
71c10d1ebe
Merge pull request #279 from tjnet/surpress_rubocop_complains_about_initalizer_file_name 
fix rubocop complains about initializer file name (use snake_case)
 2018-03-07 20:27:41 -03:00
Gonzalo Rodriguez
c1777e0f63
Merge pull request #285 from alextaylor000/patch-1 
Mention 'match_discriminator' in README.md
 2018-03-07 20:17:35 -03:00
Alex Taylor
993d724b64
Mention 'match_discriminator' in README.md 2018-03-05 17:21:36 -08:00
jun_tanaka555
70a4c1f933 fix rubocop complains about initializer file name 2018-02-04 16:18:54 +09:00
Gonzalo Rodriguez
d6d471fea5 Move all dependencies to gemspec 2018-02-02 16:05:04 -03:00
Gonzalo Rodriguez
53095231cc Test against rails 5.2.0.rc to get early feedback without causing TravisCI build failures 2018-02-02 13:14:21 -03:00
Gonzalo Rodriguez
7bb7a05987 Help users understand more clearly when the store is misconfigured 2018-02-01 10:06:39 -03:00
Corey Farwell
39c04b311f
Merge pull request #273 from grzuy/readme_dont_depend_activesupport 
Don't make README examples depend on activesupport
 2018-01-31 18:16:38 -05:00
Gonzalo Rodriguez
16af283d28 Don't make README examples depend on activesupport 2018-01-31 19:12:52 -03:00
Gonzalo Rodriguez
f27432df91 Use Rack::Lint in tests to check any change continues complying with the rack spec 2018-01-30 10:08:20 -03:00
Corey Farwell
9f79ab272e
Merge pull request #265 from grzuy/test_remove_dup 
Remove request duplication in rack_attack_spec.rb
 2018-01-29 11:31:01 -05:00
Gonzalo Rodriguez
6af29fb44e Avoid 'defined?' buggy behavior in ruby 2.5.0. Fixes #253 
'defined?' is buggy in ruby 2.5.0, which under certain circumstances
users using rack-attack can hit. See issue #253.

I reported (https://bugs.ruby-lang.org/issues/14407) and
fixed (https://github.com/ruby/ruby/pull/1800) the issue in
ruby already, but i guess i would take some time before there's
a new ruby release including that fix.

So for now we would need to circumvent this bug by using
'const_defined?' instead of 'defined?' for this particular case.

More details:

Anyone using:
  * ruby 2.5.0
  * redis
  * rack-attack without redis-store and using at least one throttle
  * having a toplevel class named Store

will hit this ruby 2.5.0 bug https://bugs.ruby-lang.org/issues/14407

That's because of the following buggy behavior of 'defined?' under ruby
2.5:

```
$ ruby -v
ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]

$ irb
> class Redis
> end
=> nil
> class Store
> end
=> nil
> defined?(::Redis::Store)
=> "constant"
> ::Redis::Store
  NameError (uninitialized constant Redis::Store
    Did you mean?  Store)
```
 2018-01-29 12:25:18 -03:00
Gonzalo Rodriguez
980633e1a9 Adds acceptance-oriented tests 2018-01-25 18:21:29 -03:00
Tieg Zaharia
d7cc49117f
Merge pull request #267 from grzuy/freeze_constants 
Do not allow mutating constants
 2018-01-25 14:51:06 -05:00
Tieg Zaharia
7048599054
Merge pull request #268 from grzuy/cleanup_self 
Cleanup unnecessary self references
 2018-01-25 14:49:58 -05:00
Gonzalo Rodriguez
b7eb7851cf Cleanup unnecessary self references 2018-01-25 15:52:20 -03:00
Gonzalo Rodriguez
7286517c2f Do not allow mutating constants 2018-01-25 12:22:40 -03:00
Gonzalo Rodriguez
73e267782b Remove request duplication in rack_attack_spec.rb 2018-01-25 10:54:19 -03:00
Gonzalo Rodriguez
ca739946ce Attempt to make it easier to understand that the method is making assertions 2018-01-25 10:53:47 -03:00
Corey Farwell
6f545e2665
Merge pull request #262 from grzuy/legibility 
Attempt to improve legibility
 2018-01-23 17:46:03 -05:00
Corey Farwell
f91f3a403c
Merge pull request #264 from grzuy/drop_support_for_rails_3 
Drop support for unmaintaned Rails 3
 2018-01-23 17:45:29 -05:00
Corey Farwell
66bb16e97a
Merge pull request #263 from grzuy/remove_warnings 
Fixes warnings in test output
 2018-01-23 17:24:11 -05:00
Gonzalo Rodriguez
218a320a3d Fixes warning instead of hiding it 
Warning was: 'warning: instance variable @data not initialized'
 2018-01-23 16:56:42 -03:00
Gonzalo Rodriguez
34ee066eac Drop support for Rails 3 2018-01-23 16:12:16 -03:00
Gonzalo Rodriguez
e8102910bf Fixes warning 'DEPRECATED: Use assert_nil if expecting nil from ...' 2018-01-23 15:07:49 -03:00
Corey Farwell
03ade2e056
Merge pull request #261 from grzuy/test_against_supported_only 
Only test against actively supported rubies and gems
 2018-01-23 12:15:48 -05:00
Gonzalo
79d21fc3ac Attempt to improve legibility 2018-01-19 12:00:38 -03:00
Gonzalo
b4436fbeb2 Try fix TravisCI build 
See:
https://github.com/travis-ci/travis-ci/issues/8978#issuecomment-354036443
 2018-01-17 14:03:08 -03:00
Gonzalo
a19f92738d Test against actively supported rubies and gems 
https://www.ruby-lang.org/en/downloads/branches://www.ruby-lang.org/en/downloads/branches/
http://guides.rubyonrails.org/maintenance_policy.html
https://www.ruby-lang.org/en/downloads/releases/
 2018-01-17 13:49:24 -03:00
Corey Farwell
d5b89f2f74
Merge pull request #260 from grzuy/update_hash_syntax_in_docs 
Update docs to use new ruby hash syntax
 2018-01-17 09:55:30 -05:00
Gonzalo
aeca8e52b3 Update to new ruby hash syntax in docs 2018-01-17 11:05:22 -03:00
Corey Farwell
62d64e5eed
Merge pull request #252 from garside/master 
Fixing whitespace issue
 2018-01-05 17:48:21 -05:00
Eric Garside
5a7114e126 Fixing whitespace issue 2018-01-05 17:38:19 -05:00
Corey Farwell
92ef924269
Merge pull request #246 from mattias-lundell/patch-1 
Fix alignment of columns
 2018-01-05 14:00:55 -05:00
Aaron Suggs
7b77f6e134
Merge pull request #242 from olleolleolle/patch-1 
Travis: jruby-9.1.14.0
 2017-11-15 09:32:52 -05:00
Olle Jonsson
9835c1028c
Travis: jruby-9.1.14.0 2017-11-12 14:12:16 +01:00
Mattias Lundell
c37b477d15 Fix alignment of columns 2017-10-11 13:55:19 +02:00
Olle Jonsson
32b64780d9 Travis: jruby-9.1.13.0 2017-09-08 13:10:40 +02:00
Aaron Suggs
037e52ba5d Merge pull request #240 from olleolleolle/patch-1 
Travis: use latest jruby-9.1.12.0
 2017-08-21 10:44:47 -04:00
Olle Jonsson
6e15637513 Travis: use latest jruby-9.1.12.0 2017-08-17 20:17:48 +02:00
Aaron Suggs
809474fa7b Merge pull request #231 from olleolleolle/patch-1 
Travis: use jruby-9.1.10.0
 2017-06-09 13:15:47 -04:00
Olle Jonsson
9e23f1acd1 Travis: use jruby-9.1.10.0 2017-05-26 12:30:17 +02:00