sjs/rack-attack
1
0
Fork 0
mirror of https://github.com/samsonjs/rack-attack.git synced 2026-03-25 09:25:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
601 commits 1 branch 0 tags 1.1 MiB
Commit graph

601 commits

This branch
This branch
All branches
Author SHA1 Message Date
Gonzalo Rodriguez
9d95bdb18e
Update TravisCI linux dist from trusty to xenial 2018-11-22 11:16:15 -03:00
Gonzalo Rodriguez
ff1cb4a445
Update CHANGELOG 2018-10-31 11:12:23 -03:00
Gonzalo Rodriguez
ef7fe67b5e
docs: fix typo 2018-10-30 10:27:46 -03:00
Gonzalo Rodriguez
093d809eae
style: don't enforce rubocop in autogenerated files 2018-10-30 10:23:32 -03:00
Gonzalo Rodriguez
e9155fffbe
Merge pull request #393 from leoarnold/leoarnold/feature/wiki_to_doc 
Move Wiki examples into version control
 2018-10-29 11:27:20 -03:00
Leo Arnold
b0da52a1bd Move Wiki examples into version control. Closes #324 2018-10-28 19:21:43 +01:00
Gonzalo Rodriguez
452ea1b849
Merge pull request #394 from grzuy/improve_misconfigured_store_exception_message 
feat: improve MisconfiguredStoreError exception message to aid debugging
 2018-10-16 00:16:42 -03:00
Gonzalo Rodriguez
8cbd3dc0fc
feat: improve MisconfiguredStoreError exception message to aid debugging 2018-10-11 11:44:10 -03:00
Gonzalo Rodriguez
3d55bfabf6
Merge pull request #392 from leoarnold/leoarnold/feature/readme_toc 
Add table of contents to README
 2018-10-08 20:29:34 -03:00
Leo Arnold
95d536414a Add table of contents to README. Closes #335 2018-10-08 18:15:07 +02:00
Gonzalo Rodriguez
014f74b95d
Merge pull request #387 from grzuy/fix_redis_3_and_memory_store 
[Fixes #355] Fix unexpected error when using redis 3 and any store which is not proxied
 2018-10-08 11:33:34 -03:00
Gonzalo Rodriguez
141f2f0759
Merge pull request #385 from grzuy/no_unwrapping 
Remove store class unwrapping completely
 2018-10-02 20:43:30 -03:00
Gonzalo Rodriguez
935f99a638
[Fixes #355] Avoid unexpected 'Gem::LoadError' for redis when not intented to be used 
It seems that the original implementation accidentally autoloaded ActiveSupport::Cache::RedisCacheStore
which once evaluated asks for redis v4 generating Gem::LoadError.

In order to bypass any unnecessary constant autoloading we can just check class name string.
 2018-09-30 22:13:30 -03:00
Gonzalo Rodriguez
82c0a17dd4
Test against Redis 3.x 2018-09-30 22:02:33 -03:00
Gonzalo Rodriguez
91dbb52235
Remove unwrapping 2018-09-30 13:32:08 -03:00
Gonzalo Rodriguez
d189a2c7ee
Update CHANGELOG 2018-09-29 18:25:44 -03:00
Gonzalo Rodriguez
fc235c90c2
Merge pull request #382 from grzuy/cleanup_redis_cache_store_proxy 
Remove unnecessary wrapping of ActiveSupport::Cache::RedisCacheStore#read
 2018-09-03 23:15:39 -03:00
Gonzalo Rodriguez
a7b50abdd5
Merge pull request #381 from grzuy/remove_obsolete_mem_cache_proxy 
Remove MemCacheProxy which existed only for now obsolete memcache-client
 2018-09-03 23:15:24 -03:00
Gonzalo Rodriguez
ef21932760
Update README: Mailing list no longer user 2018-09-03 18:35:08 -03:00
Gonzalo Rodriguez
55411e5e82
Remove MemCacheProxy which existed only for now obsolete memcache-client 2018-09-03 18:24:21 -03:00
Gonzalo Rodriguez
7001178b6d
Remove unnecessary wrapping of ActiveSupport::Cache::RedisCacheStore#read 
`raw: true` isn't doing anything special for `read`, only for `write`
 2018-09-03 17:55:29 -03:00
Gonzalo Rodriguez
717cf4def3
Merge pull request #374 from jdelStrother/connection-pool 
Fix usage with connection-pooled MemCacheStore
 2018-09-03 17:45:00 -03:00
Jonathan del Strother
5cdc15b35a Add a proxy to deal with ActiveSupport::Cache::MemCacheStore 
If connection pooling is used with AS::Cache::MemCacheStore,
unwrap_active_support_stores wouldn't return the underlying dalli instance(s),
and so Rack::Attack.store would be the bare unproxied MemCacheStore instance.

Calling write then increment would silently fail because :raw wasn't used.

With this commit, we no longer try to unwrap AS::Cache::MemCacheStore instances.
 2018-09-03 12:00:02 +01:00
Jonathan del Strother
03b8ce6f9e
Refactor the "doesn't leak keys" spec 2018-08-30 21:52:13 -03:00
Gonzalo Rodriguez
fab29695f9
Merge pull request #378 from grzuy/update 
Update development gems
 2018-08-20 13:56:24 -03:00
Gonzalo Rodriguez
3b97b7d2e9
Update development gems 2018-08-17 16:55:18 -03:00
Gonzalo Rodriguez
264770451b
Merge pull request #377 from krainboltgreene/patch-1 
Prefer to not use X- style headers for clarity
 2018-08-16 15:05:47 -03:00
Kurtis Rainbolt-Greene
ea58ccbb6a
Forgot to match the header 2018-08-16 10:32:02 -07:00
Kurtis Rainbolt-Greene
3e5a4607cd
Prefer to not use X- style headers for clarity 
The IETF decided the X- style custom headers have caused more headache than the value: https://tools.ietf.org/html/rfc6648 so this tool (which is very popular and much loved) shouldn't suggest using an old style.
 2018-08-16 08:11:30 -07:00
Gonzalo Rodriguez
516660b55c
Merge pull request #376 from carlos-contreras/fix-safelist-copy-on-readme 
Fix copy on safelist description
 2018-07-31 18:05:55 -03:00
Carlos Contreras
711ba9bf99 Fix copy on safelist description 2018-07-31 15:38:16 -05:00
Gonzalo Rodriguez
3ed014d45a
Merge pull request #373 from grzuy/jruby 
Stop running TravisCI against jRuby for now
 2018-07-02 18:57:39 -03:00
Gonzalo Rodriguez
db10436452
Update CHANGELOG 2018-07-02 14:26:56 -03:00
Gonzalo Rodriguez
eaaa60ec44
Stop running TravisCI against jRuby for now 
I am starting to find it difficult to argue in favor of having jruby in
the list of TravisCI rubies.

It adds a bit of extra cost in maintenance and time spent waiting build to finish,
without feeling we're getting a lot out of it. Thus, the feeling is that it has low ROI.

Reasons behind my feeling of not "getting a lot out of it" includes:

- Almost never coming across a situation in which I thought to myself
"Hey, with this change we're making the gem incompatible with jRuby" because most
of the failures on jRuby builds where either heisenbugs and/or rvm installation
problems with jRuby, at least in my experience

- Usage share seems to be very very low, even compared to unmaintaned
MRI version, according to some sources, e.g.
https://semaphoreci.com/blog/2017/11/08/ruby-versions-used-in-commercial-projects-in-2017.html
 2018-07-02 14:09:17 -03:00
Gonzalo Rodriguez
e4a8c1ce1f
Merge pull request #369 from grzuy/test_plain_redis 
Acceptance test plain redis as a cache store backend
 2018-06-29 17:23:10 -03:00
Gonzalo Rodriguez
e295ede874
Use RedisStoreProxy (not RedisProxy) for Redis::Store 2018-06-29 16:48:40 -03:00
Gonzalo Rodriguez
673cf98157
Avoid as much repetition as possible between RedisProxy and RedisStoreProxy 2018-06-29 15:44:41 -03:00
Gonzalo Rodriguez
b40b5718dc
rubocop --auto-correct 2018-06-29 15:41:36 -03:00
Gonzalo Rodriguez
e50bfbebaa
Acceptance test plain redis as a cache store backend 2018-06-29 15:41:04 -03:00
Gonzalo Rodriguez
6fbb6c8b1c
Merge branch 'master' into support-redis-gem 2018-06-29 15:40:45 -03:00
Gonzalo Rodriguez
3634f79e3d
Merge pull request #356 from grzuy/spec_helper_requires 
Remove unnecessary requires in spec_helper
 2018-06-29 15:30:08 -03:00
Gonzalo Rodriguez
eb07d9789f
Prefer Gem::Version for version comparisons 2018-06-29 15:27:36 -03:00
Gonzalo Rodriguez
85c4c085c9
Remove duplicated #initialize 2018-06-29 15:27:20 -03:00
Gonzalo Rodriguez
d1682b19b4
Merge remote-tracking branch 'rfwatson/master' 2018-06-29 15:24:13 -03:00
Gonzalo Rodriguez
aca4078089
Remove unnecessary requires in spec_helper 2018-06-29 11:47:04 -03:00
Gonzalo Rodriguez
73bc739d5a
Merge remote-tracking branch 'doliveirakn/master' 2018-06-29 11:17:19 -03:00
Gonzalo Rodriguez
19e17562c1
Merge pull request #372 from grzuy/drop_deprecated_methods 
Remove previously deprecated public methods
 2018-06-28 19:12:41 -03:00
Gonzalo Rodriguez
7458023644
Merge pull request #365 from grzuy/remove_ruby_2_2 
Remove support for unmaintained ruby 2.2
 2018-06-28 18:15:24 -03:00
Gonzalo Rodriguez
1c1ee918e1
Remove previously deprecated public methods 2018-06-28 17:16:33 -03:00
Gonzalo Rodriguez
8315a1e7e1
Remove support for unmaintained ruby 2.2 2018-06-28 17:08:15 -03:00